-
Notifications
You must be signed in to change notification settings - Fork 43
/
Copy pathProviderRepositoryTest.java
356 lines (290 loc) · 15.6 KB
/
ProviderRepositoryTest.java
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
package dev.openfeature.sdk;
import static dev.openfeature.sdk.fixtures.ProviderFixture.createMockedErrorProvider;
import static dev.openfeature.sdk.fixtures.ProviderFixture.createMockedProvider;
import static dev.openfeature.sdk.fixtures.ProviderFixture.createMockedReadyProvider;
import static dev.openfeature.sdk.testutils.stubbing.ConditionStubber.doDelayResponse;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatCode;
import static org.awaitility.Awaitility.await;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.doThrow;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.timeout;
import static org.mockito.Mockito.verify;
import java.time.Duration;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.Future;
import java.util.function.BiConsumer;
import java.util.function.Consumer;
import java.util.function.Function;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Nested;
import org.junit.jupiter.api.Test;
import dev.openfeature.sdk.exceptions.OpenFeatureError;
import dev.openfeature.sdk.testutils.exception.TestException;
class ProviderRepositoryTest {
private static final String CLIENT_NAME = "client name";
private static final String ANOTHER_CLIENT_NAME = "another client name";
private static final int TIMEOUT = 5000;
private final ExecutorService executorService = Executors.newCachedThreadPool();
private ProviderRepository providerRepository;
@BeforeEach
void setupTest() {
providerRepository = new ProviderRepository();
}
@Nested
class InitializationBehavior {
@Nested
class DefaultProvider {
@Test
@DisplayName("should reject null as default provider")
void shouldRejectNullAsDefaultProvider() {
assertThatCode(() -> providerRepository.setProvider(null, mockAfterSet(), mockAfterInit(),
mockAfterShutdown(), mockAfterError(), false)).isInstanceOf(IllegalArgumentException.class);
}
@Test
@DisplayName("should have NoOpProvider set as default on initialization")
void shouldHaveNoOpProviderSetAsDefaultOnInitialization() {
assertThat(providerRepository.getProvider()).isInstanceOf(NoOpProvider.class);
}
@Test
@DisplayName("should immediately return when calling the provider mutator")
void shouldImmediatelyReturnWhenCallingTheProviderMutator() throws Exception {
FeatureProvider featureProvider = createMockedProvider();
doDelayResponse(Duration.ofSeconds(10)).when(featureProvider).initialize(new ImmutableContext());
await()
.alias("wait for provider mutator to return")
.pollDelay(Duration.ofMillis(1))
.atMost(Duration.ofSeconds(1))
.until(() -> {
providerRepository.setProvider(featureProvider, mockAfterSet(), mockAfterInit(),
mockAfterShutdown(), mockAfterError(), false);
verify(featureProvider, timeout(TIMEOUT)).initialize(any());
return true;
});
verify(featureProvider, timeout(TIMEOUT)).initialize(any());
}
@Test
@DisplayName("should avoid additional initialization call if provider has been initialized already")
void shouldAvoidAdditionalInitializationCallIfProviderHasBeenInitializedAlready() throws Exception {
FeatureProvider provider = createMockedReadyProvider();
setFeatureProvider(provider);
verify(provider, never()).initialize(any());
}
}
@Nested
class NamedProvider {
@Test
@DisplayName("should reject null as named provider")
void shouldRejectNullAsNamedProvider() {
assertThatCode(() -> providerRepository.setProvider(CLIENT_NAME, null, mockAfterSet(), mockAfterInit(),
mockAfterShutdown(), mockAfterError(), false))
.isInstanceOf(IllegalArgumentException.class);
}
@Test
@DisplayName("should reject null as client name")
void shouldRejectNullAsDefaultProvider() {
NoOpProvider provider = new NoOpProvider();
assertThatCode(() -> providerRepository.setProvider(null, provider, mockAfterSet(), mockAfterInit(),
mockAfterShutdown(), mockAfterError(), false))
.isInstanceOf(IllegalArgumentException.class);
}
@Test
@DisplayName("should immediately return when calling the named client provider mutator")
void shouldImmediatelyReturnWhenCallingTheNamedClientProviderMutator() throws Exception {
FeatureProvider featureProvider = createMockedProvider();
doDelayResponse(Duration.ofSeconds(10)).when(featureProvider).initialize(any());
await()
.alias("wait for provider mutator to return")
.pollDelay(Duration.ofMillis(1))
.atMost(Duration.ofSeconds(1))
.until(() -> {
providerRepository.setProvider("named client", featureProvider, mockAfterSet(),
mockAfterInit(), mockAfterShutdown(), mockAfterError(), false);
verify(featureProvider, timeout(TIMEOUT)).initialize(any());
return true;
});
}
@Test
@DisplayName("should avoid additional initialization call if provider has been initialized already")
void shouldAvoidAdditionalInitializationCallIfProviderHasBeenInitializedAlready() throws Exception {
FeatureProvider provider = createMockedReadyProvider();
setFeatureProvider(CLIENT_NAME, provider);
verify(provider, never()).initialize(any());
}
}
}
@Nested
class ShutdownBehavior {
@Nested
class DefaultProvider {
@Test
@DisplayName("should immediately return when calling the provider mutator")
void shouldImmediatelyReturnWhenCallingTheProviderMutator() throws Exception {
FeatureProvider newProvider = createMockedProvider();
doDelayResponse(Duration.ofSeconds(10)).when(newProvider).initialize(any());
await()
.alias("wait for provider mutator to return")
.pollDelay(Duration.ofMillis(1))
.atMost(Duration.ofSeconds(1))
.until(() -> {
providerRepository.setProvider(newProvider, mockAfterSet(), mockAfterInit(),
mockAfterShutdown(), mockAfterError(), false);
verify(newProvider, timeout(TIMEOUT)).initialize(any());
return true;
});
verify(newProvider, timeout(TIMEOUT)).initialize(any());
}
@Test
@DisplayName("should not call shutdown if replaced default provider is bound as named provider")
void shouldNotCallShutdownIfReplacedDefaultProviderIsBoundAsNamedProvider() {
FeatureProvider oldProvider = createMockedProvider();
FeatureProvider newProvider = createMockedProvider();
setFeatureProvider(oldProvider);
setFeatureProvider(CLIENT_NAME, oldProvider);
setFeatureProvider(newProvider);
verify(oldProvider, never()).shutdown();
}
}
@Nested
class NamedProvider {
@Test
@DisplayName("should immediately return when calling the provider mutator")
void shouldImmediatelyReturnWhenCallingTheProviderMutator() throws Exception {
FeatureProvider newProvider = createMockedProvider();
doDelayResponse(Duration.ofSeconds(10)).when(newProvider).initialize(any());
Future<?> providerMutation = executorService
.submit(() -> providerRepository.setProvider(CLIENT_NAME, newProvider, mockAfterSet(),
mockAfterInit(), mockAfterShutdown(), mockAfterError(), false));
await()
.alias("wait for provider mutator to return")
.pollDelay(Duration.ofMillis(1))
.atMost(Duration.ofSeconds(1))
.until(providerMutation::isDone);
}
@Test
@DisplayName("should not call shutdown if replaced provider is bound to multiple names")
void shouldNotCallShutdownIfReplacedProviderIsBoundToMultipleNames() throws InterruptedException {
FeatureProvider oldProvider = createMockedProvider();
FeatureProvider newProvider = createMockedProvider();
setFeatureProvider(CLIENT_NAME, oldProvider);
setFeatureProvider(ANOTHER_CLIENT_NAME, oldProvider);
setFeatureProvider(CLIENT_NAME, newProvider);
verify(oldProvider, never()).shutdown();
}
@Test
@DisplayName("should not call shutdown if replaced provider is bound as default provider")
void shouldNotCallShutdownIfReplacedProviderIsBoundAsDefaultProvider() {
FeatureProvider oldProvider = createMockedProvider();
FeatureProvider newProvider = createMockedProvider();
setFeatureProvider(oldProvider);
setFeatureProvider(CLIENT_NAME, oldProvider);
setFeatureProvider(CLIENT_NAME, newProvider);
verify(oldProvider, never()).shutdown();
}
@Test
@DisplayName("should not throw exception if provider throws one on shutdown")
void shouldNotThrowExceptionIfProviderThrowsOneOnShutdown() {
FeatureProvider provider = createMockedProvider();
doThrow(TestException.class).when(provider).shutdown();
setFeatureProvider(provider);
assertThatCode(() -> setFeatureProvider(new NoOpProvider())).doesNotThrowAnyException();
verify(provider, timeout(TIMEOUT)).shutdown();
}
}
@Nested
class LifecyleLambdas {
@Test
@DisplayName("should run afterSet, afterInit, afterShutdown on successful set/init")
@SuppressWarnings("unchecked")
void shouldRunLambdasOnSuccessful() {
Consumer<FeatureProvider> afterSet = mock(Consumer.class);
Consumer<FeatureProvider> afterInit = mock(Consumer.class);
Consumer<FeatureProvider> afterShutdown = mock(Consumer.class);
BiConsumer<FeatureProvider, OpenFeatureError> afterError = mock(BiConsumer.class);
FeatureProvider oldProvider = providerRepository.getProvider();
FeatureProvider featureProvider1 = createMockedProvider();
FeatureProvider featureProvider2 = createMockedProvider();
setFeatureProvider(featureProvider1, afterSet, afterInit, afterShutdown, afterError);
setFeatureProvider(featureProvider2);
verify(afterSet, timeout(TIMEOUT)).accept(featureProvider1);
verify(afterInit, timeout(TIMEOUT)).accept(featureProvider1);
verify(afterShutdown, timeout(TIMEOUT)).accept(oldProvider);
verify(afterError, never()).accept(any(), any());
}
@Test
@DisplayName("should run afterSet, afterError on unsuccessful set/init")
@SuppressWarnings("unchecked")
void shouldRunLambdasOnError() throws Exception {
Consumer<FeatureProvider> afterSet = mock(Consumer.class);
Consumer<FeatureProvider> afterInit = mock(Consumer.class);
Consumer<FeatureProvider> afterShutdown = mock(Consumer.class);
BiConsumer<FeatureProvider, OpenFeatureError> afterError = mock(BiConsumer.class);
FeatureProvider errorFeatureProvider = createMockedErrorProvider();
setFeatureProvider(errorFeatureProvider, afterSet, afterInit, afterShutdown, afterError);
verify(afterSet, timeout(TIMEOUT)).accept(errorFeatureProvider);
verify(afterInit, never()).accept(any());;
verify(afterError, timeout(TIMEOUT)).accept(eq(errorFeatureProvider), any());
}
}
}
@Test
@DisplayName("should shutdown all feature providers on shutdown")
void shouldShutdownAllFeatureProvidersOnShutdown() {
FeatureProvider featureProvider1 = createMockedProvider();
FeatureProvider featureProvider2 = createMockedProvider();
setFeatureProvider(featureProvider1);
setFeatureProvider(CLIENT_NAME, featureProvider1);
setFeatureProvider(ANOTHER_CLIENT_NAME, featureProvider2);
providerRepository.shutdown();
verify(featureProvider1, timeout(TIMEOUT)).shutdown();
verify(featureProvider2, timeout(TIMEOUT)).shutdown();
}
private void setFeatureProvider(FeatureProvider provider) {
providerRepository.setProvider(provider, mockAfterSet(), mockAfterInit(), mockAfterShutdown(),
mockAfterError(), false);
waitForSettingProviderHasBeenCompleted(ProviderRepository::getProvider, provider);
}
private void setFeatureProvider(FeatureProvider provider, Consumer<FeatureProvider> afterSet,
Consumer<FeatureProvider> afterInit, Consumer<FeatureProvider> afterShutdown,
BiConsumer<FeatureProvider, OpenFeatureError> afterError) {
providerRepository.setProvider(provider, afterSet, afterInit, afterShutdown,
afterError, false);
waitForSettingProviderHasBeenCompleted(ProviderRepository::getProvider, provider);
}
private void setFeatureProvider(String namedProvider, FeatureProvider provider) {
providerRepository.setProvider(namedProvider, provider, mockAfterSet(), mockAfterInit(), mockAfterShutdown(),
mockAfterError(), false);
waitForSettingProviderHasBeenCompleted(repository -> repository.getProvider(namedProvider), provider);
}
private void waitForSettingProviderHasBeenCompleted(
Function<ProviderRepository, FeatureProvider> extractor,
FeatureProvider provider) {
await()
.pollDelay(Duration.ofMillis(1))
.atMost(Duration.ofSeconds(5))
.until(() -> {
return extractor.apply(providerRepository) == provider;
});
}
private Consumer<FeatureProvider> mockAfterSet() {
return fp -> {
};
}
private Consumer<FeatureProvider> mockAfterInit() {
return fp -> {
};
}
private Consumer<FeatureProvider> mockAfterShutdown() {
return fp -> {
};
}
private BiConsumer<FeatureProvider, OpenFeatureError> mockAfterError() {
return (fp, ex) -> {
};
}
}