Make emitterExecutor static

The emitterExecutor in EventProvider can be a single pool for all
EventProviders.

Increase timeout for EventsTest consumption as it can cause intermitten failures
due to execution being moved to thread pool

Fix onEmit reference, to be captured as a local variable.

Signed-off-by: Philipp Fehre <[email protected]>

Author: Philipp Fehre

Diff for: src/main/java/dev/openfeature/sdk/EventProvider.java

@@ -22,7 +22,7 @@
 public abstract class EventProvider implements FeatureProvider {
     private EventProviderListener eventProviderListener;
     private static final int SHUTDOWN_TIMEOUT_SECONDS = 3;
-    private final ExecutorService emitterExecutor = Executors.newCachedThreadPool(runnable -> {
+    private static final ExecutorService emitterExecutor = Executors.newCachedThreadPool(runnable -> {
         final Thread thread = new Thread(runnable);
         thread.setDaemon(true);
         return thread;
@@ -85,8 +85,10 @@ public void emit(ProviderEvent event, ProviderEventDetails details) {
         if (eventProviderListener != null) {
             eventProviderListener.onEmit(event, details);
         }
-        if (this.onEmit != null) {
-            emitterExecutor.submit(() -> this.onEmit.accept(this, event, details));
+
+        final TriConsumer<EventProvider, ProviderEvent, ProviderEventDetails> localOnEmit = this.onEmit;
+        if (localOnEmit != null) {
+            emitterExecutor.submit(() -> localOnEmit.accept(this, event, details));
         }
     }
 
@@ -97,7 +99,6 @@ public void emit(ProviderEvent event, ProviderEventDetails details) {
      * @param details The details of the event
      */
     public void emitProviderReady(ProviderEventDetails details) {
-        System.out.println("Details: " + details);
         emit(ProviderEvent.PROVIDER_READY, details);
     }
 

Diff for: src/test/java/dev/openfeature/sdk/EventsTest.java

@@ -19,7 +19,7 @@
 
 class EventsTest {
 
-    private static final int TIMEOUT = 300;
+    private static final int TIMEOUT = 500;
     private static final int INIT_DELAY = TIMEOUT / 2;
 
     @AfterAll