fix: hooks not run in NOT_READY/FATAL #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
force-pushed
the
fix/fatal-not-running-hooks-appropriately
branch
from
cd7f5cc to
539e787
Compare
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
fix/fatal-not-running-hooks-appropriately
branch
from
539e787 to
72ce106
Compare
Signed-off-by: Todd Baert <[email protected]>
|
toddbaert
commented
Mar 26, 2025
Comment on lines
-181
to
-186
| if (ProviderState.NOT_READY.equals(state)) { | ||
| throw new ProviderNotReadyError("provider not yet initialized"); | ||
| } | ||
| if (ProviderState.FATAL.equals(state)) { | ||
| throw new FatalError("provider is in an irrecoverable error state"); | ||
| } |
There was a problem hiding this comment.
Throwing these before we ran the hooks and setup the afterHookContext was the cause of the issue. We just needed to move it later.
toddbaert
commented
Mar 26, 2025
| @@ -594,6 +594,25 @@ void erroneous_flagResolution_setsAppropriateFieldsInFlagEvaluationDetails() { | |||
| assertThat(evaluationDetails.getValue()).isTrue(); | |||
| } | |||
|
|
|||
| @Test | |||
| void shortCircuit_flagResolution_runsHooksWithAllFields() { | |||
There was a problem hiding this comment.
This test fails without the fix.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1392 +/- ##
============================================
+ Coverage 92.90% 93.25% +0.35%
- Complexity 470 471 +1
============================================
Files 43 43
Lines 1127 1127
Branches 91 91
============================================
+ Hits 1047 1051 +4
+ Misses 53 48 -5
- Partials 27 28 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aepfli
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where our "short circuit" logic was "short circuiting" too early, leading to various errors in hooks.
Fixes: #1370