Skip to content

Update SDK to be compliant with spec v0.2.0 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
7 tasks done
beeme1mr opened this issue Aug 5, 2022 · 4 comments
Closed
7 tasks done

Update SDK to be compliant with spec v0.2.0 #42

beeme1mr opened this issue Aug 5, 2022 · 4 comments
Assignees

Comments

@beeme1mr
Copy link
Member

beeme1mr commented Aug 5, 2022

Update the SDK to be compliant with the v0.2.0 spec.

Flag Evaluation API

  • #116 - Have different methods for float and int

Providers

  • #119 - Remove context transformers. Add provider hooks

Evaluation Context

  • #117 - Ensure context merging behavior is correct
  • #120 - Add the ability to fetch all custom fields
  • #121 - Ensure evaluation context keys are unique

Hooks

  • #119 - Ensure provider hook are correctly ordered

Full Changelog: open-feature/spec@v0.1.0...v0.2.0

@justinabrahms justinabrahms self-assigned this Aug 5, 2022
@justinabrahms
Copy link
Member

Still remaining:

In the spec, but not in our tests: 
  4.4.7: If an error occurs in the before hooks, the default value MUST be returned.
  3.2.1: The API, Client and invocation MUST have a method for supplying evaluation context.
  3.2.2: Evaluation context MUST be merged in the order: API (global) - client - invocation, with duplicate values being overwritten.
  3.1.4: The evaluation context fields MUST have an unique key.

@justinabrahms
Copy link
Member

Done. We'll call this ticket done when #43 is resolved.

@beeme1mr
Copy link
Member Author

beeme1mr commented Aug 8, 2022

Great, thanks Justin.

@beeme1mr beeme1mr closed this as completed Aug 8, 2022
@justinabrahms justinabrahms reopened this Aug 8, 2022
@beeme1mr
Copy link
Member Author

beeme1mr commented Aug 8, 2022

Ah, sorry. I misread your comment. I'll leave it alone 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants