fix: ability to set provider after shutdown #556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #556 +/- ##
============================================
- Coverage 95.36% 95.11% -0.25%
+ Complexity 330 329 -1
============================================
Files 31 31
Lines 755 758 +3
Branches 37 37
============================================
+ Hits 720 721 +1
- Misses 18 20 +2
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
thomaspoignant
approved these changes
Aug 11, 2023
beeme1mr
approved these changes
Aug 11, 2023
Signed-off-by: Kavindu Dodanduwa <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
toddbaert
changed the title
|
@Kavindu-Dodan I've updated the PR title to be a bit more precise, IMO. |
toddbaert
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fix #552
Since API is a singleton, we must re-initialize all cleaned-up resources.