Skip to content

Commit bd57177

Browse files
beeme1mrbeeme1mr
authored
chore: fix lint issues and bump server sdk version (#715)
Signed-off-by: Michael Beemer <[email protected]>
1 parent f6a39a2 commit bd57177

File tree

19 files changed

+57
-37
lines changed

19 files changed

+57
-37
lines changed

‎.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ Thumbs.db
4141

4242
# generated files
4343
proto
44+
.nx
4445

4546
# yalc stuff
4647
.yalc

‎libs/hooks/open-telemetry/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
"current-version": "echo $npm_package_version"
1515
},
1616
"peerDependencies": {
17-
"@openfeature/server-sdk": "^1.6.0",
17+
"@openfeature/server-sdk": "^1.8.0",
1818
"@opentelemetry/api": ">=1.3.0"
1919
},
2020
"license": "Apache-2.0"
21-
}
21+
}

‎libs/hooks/open-telemetry/src/lib/metrics/metrics-hook.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ describe(MetricsHook.name, () => {
225225
} as EvaluationDetails<number>;
226226

227227
// configure a mapper that throws
228-
const attributeMapper: AttributeMapper = (_) => {
228+
const attributeMapper: AttributeMapper = () => {
229229
throw new Error('fake error');
230230
};
231231
const hook = new MetricsHook({ attributeMapper });

‎libs/hooks/open-telemetry/src/lib/traces/tracing-hook.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ describe('OpenTelemetry Hooks', () => {
148148
describe('error in mapper', () => {
149149
beforeEach(() => {
150150
tracingHook = new TracingHook({
151-
attributeMapper: (_) => {
151+
attributeMapper: () => {
152152
throw new Error('fake error');
153153
},
154154
});

‎libs/providers/config-cat/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"current-version": "echo $npm_package_version"
77
},
88
"peerDependencies": {
9-
"@openfeature/server-sdk": "^1.6.0",
9+
"@openfeature/server-sdk": "^1.8.0",
1010
"configcat-js": "^8.0.0"
1111
}
12-
}
12+
}

‎libs/providers/config-cat/src/lib/config-cat-provider.spec.ts

+1
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ describe('ConfigCatProvider', () => {
3939
await provider.initialize();
4040

4141
// Currently there is no option to get access to the event emitter
42+
// eslint-disable-next-line @typescript-eslint/no-explicit-any
4243
configCatEmitter = (provider.configCatClient as any).options.hooks;
4344
});
4445

‎libs/providers/env-var/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@
66
"current-version": "echo $npm_package_version"
77
},
88
"peerDependencies": {
9-
"@openfeature/server-sdk": "^1.6.0"
9+
"@openfeature/server-sdk": "^1.8.0"
1010
}
11-
}
11+
}

‎libs/providers/flagd/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@
66
"current-version": "echo $npm_package_version"
77
},
88
"dependencies": {
9-
"@openfeature/flagd-core": "~0.1.4"
9+
"@openfeature/flagd-core": "~0.1.7"
1010
},
1111
"peerDependencies": {
1212
"@grpc/grpc-js": "~1.8.0 || ~1.9.0",
13-
"@openfeature/server-sdk": ">=1.6.0"
13+
"@openfeature/server-sdk": ">=1.8.0"
1414
}
15-
}
15+
}

‎libs/providers/flagd/src/e2e/setup-in-process-provider.ts

+15-7
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,25 @@ import { OpenFeature } from '@openfeature/server-sdk';
33
import { FlagdProvider } from '../lib/flagd-provider';
44

55
const FLAGD_NAME = 'flagd Provider';
6+
const E2E_CLIENT_NAME = 'e2e';
7+
const UNSTABLE_CLIENT_NAME = 'unstable';
68

79
// register the flagd provider before the tests.
810
console.log('Setting flagd provider...');
911
OpenFeature.setProvider(
10-
'e2e',
12+
E2E_CLIENT_NAME,
1113
new FlagdProvider({ cache: 'disabled', resolverType: 'in-process', host: 'localhost', port: 9090 }),
1214
);
13-
OpenFeature.setProvider('unstable', new FlagdProvider({ resolverType: 'in-process', host: 'localhost', port: 9091 }));
14-
// TODO: update with correct assertions once we have ability to get providerMetadata for any provider
15-
// assert(
16-
// OpenFeature.providerMetadata.name === FLAGD_NAME,
17-
// new Error(`Expected ${FLAGD_NAME} provider to be configured, instead got: ${OpenFeature.providerMetadata.name}`),
18-
// );
15+
OpenFeature.setProvider(
16+
UNSTABLE_CLIENT_NAME,
17+
new FlagdProvider({ resolverType: 'in-process', host: 'localhost', port: 9091 }),
18+
);
19+
assert(
20+
OpenFeature.getProviderMetadata(E2E_CLIENT_NAME).name === FLAGD_NAME,
21+
new Error(`Expected ${FLAGD_NAME} provider to be configured, instead got: ${OpenFeature.providerMetadata.name}`),
22+
);
23+
assert(
24+
OpenFeature.getProviderMetadata(UNSTABLE_CLIENT_NAME).name === FLAGD_NAME,
25+
new Error(`Expected ${FLAGD_NAME} provider to be configured, instead got: ${OpenFeature.providerMetadata.name}`),
26+
);
1927
console.log('flagd provider configured!');

‎libs/providers/flagd/src/e2e/setup-rpc-provider.ts

+12-7
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,19 @@ import { OpenFeature } from '@openfeature/server-sdk';
33
import { FlagdProvider } from '../lib/flagd-provider';
44

55
const FLAGD_NAME = 'flagd Provider';
6+
const E2E_CLIENT_NAME = 'e2e';
7+
const UNSTABLE_CLIENT_NAME = 'unstable';
68

79
// register the flagd provider before the tests.
810
console.log('Setting flagd provider...');
9-
OpenFeature.setProvider('e2e', new FlagdProvider({ cache: 'disabled' }));
10-
OpenFeature.setProvider('unstable', new FlagdProvider({ cache: 'disabled', port: 8014 }));
11-
// TODO: update with correct assertions once we have ability to get providerMetadata for any provider
12-
// assert(
13-
// OpenFeature.providerMetadata.name === FLAGD_NAME,
14-
// new Error(`Expected ${FLAGD_NAME} provider to be configured, instead got: ${OpenFeature.providerMetadata.name}`),
15-
// );
11+
OpenFeature.setProvider(E2E_CLIENT_NAME, new FlagdProvider({ cache: 'disabled' }));
12+
OpenFeature.setProvider(UNSTABLE_CLIENT_NAME, new FlagdProvider({ cache: 'disabled', port: 8014 }));
13+
assert(
14+
OpenFeature.getProviderMetadata(E2E_CLIENT_NAME).name === FLAGD_NAME,
15+
new Error(`Expected ${FLAGD_NAME} provider to be configured, instead got: ${OpenFeature.providerMetadata.name}`),
16+
);
17+
assert(
18+
OpenFeature.getProviderMetadata(UNSTABLE_CLIENT_NAME).name === FLAGD_NAME,
19+
new Error(`Expected ${FLAGD_NAME} provider to be configured, instead got: ${OpenFeature.providerMetadata.name}`),
20+
);
1621
console.log('flagd provider configured!');

‎libs/providers/flagd/src/e2e/step-definitions/flagd.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ defineFeature(feature, (test) => {
5252
then('the PROVIDER_CONFIGURATION_CHANGED handler must run', () => {
5353
expect(ran).toBeTruthy();
5454
});
55-
and(/^the event details must indicate "(.*)" was altered$/, (arg0) => {
55+
and(/^the event details must indicate "(.*)" was altered$/, () => {
5656
// not supported
5757
});
5858
});

‎libs/providers/flagd/src/lib/configuration.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { FlagdProviderOptions, getConfig } from './configuration';
2-
import { DEFAULT_MAX_CACHE_SIZE, DEFAULT_MAX_EVENT_STREAM_RETRIES } from './constants';
2+
import { DEFAULT_MAX_CACHE_SIZE } from './constants';
33

44
describe('Configuration', () => {
55
const OLD_ENV = process.env;

‎libs/providers/flagd/src/lib/configuration.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { DEFAULT_MAX_CACHE_SIZE, DEFAULT_MAX_EVENT_STREAM_RETRIES } from './constants';
1+
import { DEFAULT_MAX_CACHE_SIZE } from './constants';
22

33
export type CacheOption = 'lru' | 'disabled';
44
export type ResolverType = 'rpc' | 'in-process';

‎libs/providers/go-feature-flag-web/src/lib/model.ts

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
/* eslint-disable @typescript-eslint/no-explicit-any */
12
import { FlagValue, ErrorCode, EvaluationContextValue } from '@openfeature/web-sdk';
23

34
/**

‎libs/providers/go-feature-flag/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@
66
"current-version": "echo $npm_package_version"
77
},
88
"peerDependencies": {
9-
"@openfeature/server-sdk": "^1.6.0"
9+
"@openfeature/server-sdk": "^1.8.0"
1010
}
11-
}
11+
}

‎libs/providers/go-feature-flag/src/lib/data-collector-hook.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ export class GoFeatureFlagDataCollectorHook implements Hook {
9191
}
9292
}
9393

94-
after(hookContext: HookContext, evaluationDetails: EvaluationDetails<FlagValue>, hookHints?: HookHints) {
94+
after(hookContext: HookContext, evaluationDetails: EvaluationDetails<FlagValue>) {
9595
if (!this.collectUnCachedEvaluation && evaluationDetails.reason !== StandardResolutionReasons.CACHED) {
9696
return;
9797
}
@@ -109,7 +109,7 @@ export class GoFeatureFlagDataCollectorHook implements Hook {
109109
this.dataCollectorBuffer?.push(event);
110110
}
111111

112-
error(hookContext: HookContext, err: unknown, hookHints?: HookHints) {
112+
error(hookContext: HookContext) {
113113
const event = {
114114
contextKind: hookContext.context['anonymous'] ? 'anonymousUser' : 'user',
115115
kind: 'feature',

‎libs/providers/launchdarkly-client/src/lib/translate-context.ts

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
/* eslint-disable @typescript-eslint/no-explicit-any */
12
//Copyright 2022 Catamorphic, Co.
23
//
34
// Licensed under the Apache License, Version 2.0 (the "License");

‎package-lock.json

+7-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
"@nx/workspace": "16.9.1",
4747
"@openfeature/core": "^0.0.21",
4848
"@openfeature/flagd-core": ">=0.1.1",
49-
"@openfeature/server-sdk": "^1.6.2",
49+
"@openfeature/server-sdk": "^1.8.0",
5050
"@openfeature/web-sdk": "^0.4.0",
5151
"@opentelemetry/sdk-metrics": "^1.15.0",
5252
"@swc-node/register": "~1.6.0",

0 commit comments

Comments
 (0)