feat(launchdarkly-client-provider): Add tracking API #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beeme1mr
approved these changes
Mar 11, 2025
|
Thanks for the PR. It's nice to see how straightforward it was to implement. Please consider briefly mentioning in the readme that tracking events are supported and possibly include an example. |
|
Updated the README.md |
beeme1mr
reviewed
Mar 11, 2025
|
Forgot to implement: https://openfeature.dev/specification/sections/tracking#requirement-621 Will make a new commit for it. |
Signed-off-by: Tommy Josépovic <[email protected]>
tjosepo
force-pushed
the
launchdarkly-client-track
branch
from
502f0da to
e90c8f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
OpenFeature.getClient().track("event-name", { someProperty: 123 })will now properly call the LaunchDarkly JavaScript SDK.How to test
Added a unit test. We just have to make sure that calling
OpenFeature.getClient().track("event-name", { someProperty: 123 })calls the underlying JavaScript SDK.