fix: improper inclusion of test deps #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
requested review from
beeme1mr,
jonathannorris,
thomaspoignant and
lukas-reining
beeme1mr
approved these changes
Mar 12, 2025
toddbaert
force-pushed
the
fix/test-deps
branch
from
7ef2ca0 to
867f01b
Compare
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
fix/test-deps
branch
from
867f01b to
901df1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where our auto dependency inclusion was a bit overactive and includes a mock server (msw) as a real dep.
This was because msw was used for a mock/test server which exists in not in a
.specor.testfile, but in atest/dir.I've updated the dependency analysis rules accordingly and this is no longer flagged to be added.