fix: init in-process error, throw on invalid rules #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
commented
Feb 13, 2024
Comment on lines
+229
to
+234
| it('should throw with invalid targeting rules', () => { | ||
| const core = new FlagdCore(); | ||
| const flagCfg = `{"flags":{"isEnabled":{"state":"ENABLED","variants":{"true":true,"false":false},"defaultVariant":"false","targeting":{"invalid": ["this is not valid targeting"]}}}}`; | ||
| core.setConfigurations(flagCfg); | ||
|
|
||
| expect(() => core.resolveBooleanEvaluation('isEnabled', false, {}, console)).toThrow(); |
There was a problem hiding this comment.
New unit test for e2e test I mentioned.
toddbaert
commented
Feb 13, 2024
| @@ -165,8 +165,7 @@ export class FlagdCore implements Storage { | |||
| try { | |||
| targetingResolution = this._targeting.applyTargeting(flagKey, flag.targeting, evalCtx); | |||
| } catch (e) { | |||
| logger.error(`Error evaluating targeting rule for flag ${flagKey}, falling back to default`, e); | |||
| targetingResolution = null; | |||
| throw new GeneralError(`Error evaluating targeting rule for flag ${flagKey}: ${(e as Error)?.message}`); | |||
There was a problem hiding this comment.
non-test change 1: throw if targeting throws, as per flagd test specs
toddbaert
commented
Feb 13, 2024
| @@ -70,39 +70,67 @@ export class GrpcFetch implements DataFetch { | |||
| ) { | |||
| this._logger?.debug('Starting gRPC sync connection'); | |||
| closeStreamIfDefined(this._syncStream); | |||
| this._syncStream = this._syncClient.syncFlags(this._request); | |||
There was a problem hiding this comment.
non-test change 2: This can throw before it ever connects, which resulted in an unhandled exception... when that happens the .on('error') handler never takes effect. This is fixed by making the catch and .on('error') both share a local method (handleError).
As you can see, all reconnect e2e tests still work with this change.
* fixes an unhandled error if sync source not available at startup * throws on invalid targeting rules as per flagd spec Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
chore/update-e2e-tests
branch
from
8b3b012 to
9ac0429
Compare
Kavindu-Dodan
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the latest e2e tests, including those added here. Here we decided that invalid targeting should throw, which required a small change in core.
I also found a bug on the in-process provider where there's an unhandled exception in startup.