Skip to content

Commit fb70631

Browse files
committed
fix: msg missing when providers return err resolutions
Signed-off-by: Todd Baert <[email protected]>
1 parent f6bc695 commit fb70631

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

packages/server/src/client/internal/open-feature-client.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@ export class OpenFeatureClient implements Client {
298298
};
299299

300300
if (resolutionDetails.errorCode) {
301-
const err = instantiateErrorByErrorCode(resolutionDetails.errorCode);
301+
const err = instantiateErrorByErrorCode(resolutionDetails.errorCode, resolutionDetails.errorMessage);
302302
await this.errorHooks(allHooksReversed, hookContext, err, options);
303303
evaluationDetails = this.getErrorEvaluationDetails(flagKey, defaultValue, err, resolutionDetails.flagMetadata);
304304
} else {

packages/shared/src/errors/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import { ProviderNotReadyError } from './provider-not-ready-error';
1010
import { TargetingKeyMissingError } from './targeting-key-missing-error';
1111
import { TypeMismatchError } from './type-mismatch-error';
1212

13-
const instantiateErrorByErrorCode = (errorCode: ErrorCode, message?: string): OpenFeatureError => {
13+
const instantiateErrorByErrorCode = (errorCode: ErrorCode, message: string | undefined): OpenFeatureError => {
1414
switch (errorCode) {
1515
case ErrorCode.FLAG_NOT_FOUND:
1616
return new FlagNotFoundError(message);

packages/web/src/client/internal/open-feature-client.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ export class OpenFeatureClient implements Client {
253253
};
254254

255255
if (resolutionDetails.errorCode) {
256-
const err = instantiateErrorByErrorCode(resolutionDetails.errorCode);
256+
const err = instantiateErrorByErrorCode(resolutionDetails.errorCode, resolutionDetails.errorMessage);
257257
this.errorHooks(allHooksReversed, hookContext, err, options);
258258
evaluationDetails = this.getErrorEvaluationDetails(flagKey, defaultValue, err, resolutionDetails.flagMetadata);
259259
} else {

0 commit comments

Comments
 (0)