feat: add polyfill for react use hook #1157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
RedbackThomson
approved these changes
Mar 5, 2025
beeme1mr
changed the title
beeme1mr
commented
Mar 6, 2025
Signed-off-by: Michael Beemer <[email protected]>
lukas-reining
approved these changes
Mar 7, 2025
toddbaert
reviewed
Apr 10, 2025
beeme1mr
changed the title
Co-authored-by: Todd Baert <[email protected]> Signed-off-by: Michael Beemer <[email protected]>
lukas-reining
approved these changes
Apr 10, 2025
toddbaert
approved these changes
Apr 10, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 14, 2025
🤖 I have created a release *beep* *boop* --- ## [1.0.0](react-sdk-v0.4.11...react-sdk-v1.0.0) (2025-04-14) ### ✨ New Features * add polyfill for react use hook ([#1157](#1157)) ([5afe61f](5afe61f)) * add support for abort controllers to event handlers ([#1151](#1151)) ([6a22483](6a22483)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: Todd Baert <[email protected]> Co-authored-by: Todd Baert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
usepolyfillNotes
Previously, the Next.JS build process would timeout when using a suspense flag hook. The reason for this is because the noop provider (which is used during a build) is never ready. That meant that the promise thrown to initiate suspense never resolved. To address this, I've added global state using a weak map that's keyed off a provider. A
useRefwon't help because the value is only retained if the component renders successfully.Note
This unblocks suspense in our demo app but does not mean NextJS is officially support (yet).
How to test
I've added some tests and manually tested in the Toggle Shop.