fix: race adding handler during init #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
commented
Jul 22, 2023
toddbaert
force-pushed
the
fix/init-emitter-race
branch
from
ae78ef9 to
51c24d7
Compare
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
fix/init-emitter-race
branch
from
51c24d7 to
b161ec3
Compare
toddbaert
commented
Jul 22, 2023
This was referenced Jul 22, 2023
toddbaert
pushed a commit
that referenced
this pull request
Jul 22, 2023
🤖 I have created a release *beep* *boop* --- ## [0.0.8](shared-v0.0.7...shared-v0.0.8) (2023-07-22) ### Features * typesafe event emitter ([#490](#490)) ([92e3a72](92e3a72)) ### Bug Fixes * race adding handler during init ([#501](#501)) ([0be9c5d](0be9c5d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
beeme1mr
pushed a commit
that referenced
this pull request
Jul 24, 2023
🤖 I have created a release *beep* *boop* --- ## [1.4.0](js-sdk-v1.3.3...js-sdk-v1.4.0) (2023-07-22) ### Features * typesafe event emitter ([#490](#490)) ([92e3a72](92e3a72)) ### Bug Fixes * race adding handler during init ([#501](#501)) ([0be9c5d](0be9c5d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
beeme1mr
pushed a commit
that referenced
this pull request
Jul 24, 2023
🤖 I have created a release *beep* *boop* --- ## [0.3.8-experimental](web-sdk-v0.3.7-experimental...web-sdk-v0.3.8-experimental) (2023-07-24) ### Features * typesafe event emitter ([#490](#490)) ([92e3a72](92e3a72)) ### Bug Fixes * onContextChanged not running for named providers ([#491](#491)) ([1ab0cc6](1ab0cc6)) * race adding handler during init ([#501](#501)) ([0be9c5d](0be9c5d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a race condition that prevents handlers added while their provider is initializing from running.