fix: run error hook when provider returns reason error or error code #926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
beeme1mr
commented
May 1, 2024
beeme1mr
requested review from
weyert,
jonathannorris,
thomaspoignant,
toddbaert and
lukas-reining
lukas-reining
approved these changes
May 2, 2024
beeme1mr
commented
May 2, 2024
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
|
Adding @maxveldink @federicobond @Kavindu-Dodan for Ruby/Python/Go SDK reference. I think we should add something to the spec about this, yes. |
toddbaert
reviewed
May 6, 2024
toddbaert
reviewed
May 6, 2024
Signed-off-by: Michael Beemer <[email protected]>
federicobond
reviewed
May 7, 2024
toddbaert
approved these changes
May 7, 2024
Signed-off-by: Michael Beemer <[email protected]>
toddbaert
approved these changes
May 8, 2024
This was referenced May 7, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 13, 2024
🤖 I have created a release *beep* *boop* --- ## [1.2.0](core-v1.1.0...core-v1.2.0) (2024-05-13) ### ✨ New Features * set context during provider init on web ([#919](#919)) ([7e6c1c6](7e6c1c6)) ### 🐛 Bug Fixes * removes exports of OpenFeatureClient class and makes event props readonly ([#918](#918)) ([e9a25c2](e9a25c2)) * run error hook when provider returns reason error or error code ([#926](#926)) ([c6d0b5d](c6d0b5d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: openfeature-peer-update-bot <[email protected]> Co-authored-by: openfeature-peer-update-bot <[email protected]> Co-authored-by: Todd Baert <[email protected]>
toddbaert
added a commit
that referenced
this pull request
May 13, 2024
🤖 I have created a release *beep* *boop* --- ## [1.14.0](server-sdk-v1.13.5...server-sdk-v1.14.0) (2024-05-13) ### 🐛 Bug Fixes * remove export of OpenFeatureClient ([#794](#794)) ([3d197f2](3d197f2)) * removes exports of OpenFeatureClient class and makes event props readonly ([#918](#918)) ([e9a25c2](e9a25c2)) * run error hook when provider returns reason error or error code ([#926](#926)) ([c6d0b5d](c6d0b5d)) ### 🧹 Chore * remove node 16 ([#875](#875)) ([c1878e4](c1878e4)) * **main:** release core 1.2.0 ([#927](#927)) ([692ad5b](692ad5b)) ### 📚 Documentation * add tip about supported usage in the install section ([#941](#941)) ([f0de667](f0de667)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: Todd Baert <[email protected]> Co-authored-by: Todd Baert <[email protected]>
toddbaert
added a commit
that referenced
this pull request
May 13, 2024
🤖 I have created a release *beep* *boop* --- ## [1.1.0](web-sdk-v1.0.3...web-sdk-v1.1.0) (2024-05-13) ### ✨ New Features * set context during provider init on web ([#919](#919)) ([7e6c1c6](7e6c1c6)) ### 🐛 Bug Fixes * remove export of OpenFeatureClient ([#794](#794)) ([3d197f2](3d197f2)) * removes exports of OpenFeatureClient class and makes event props readonly ([#918](#918)) ([e9a25c2](e9a25c2)) * run error hook when provider returns reason error or error code ([#926](#926)) ([c6d0b5d](c6d0b5d)) * skip reconciling event for synchronous onContextChange operations ([#931](#931)) ([6c25f29](6c25f29)) ### 🧹 Chore * **main:** release core 1.2.0 ([#927](#927)) ([692ad5b](692ad5b)) ### 📚 Documentation * add tip about supported usage in the install section ([#941](#941)) ([f0de667](f0de667)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: Todd Baert <[email protected]> Co-authored-by: Todd Baert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #925
Notes
Based on a conversation in Slack: https://cloud-native.slack.com/archives/C06E4DE6S07/p1714581197391509