Skip to content

sidecarConfiguration.resources in helm chart is ignored #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mng1dev opened this issue May 3, 2024 · 2 comments · Fixed by #639
Closed

sidecarConfiguration.resources in helm chart is ignored #630

mng1dev opened this issue May 3, 2024 · 2 comments · Fixed by #639
Assignees
Labels
bug Something isn't working

Comments

@mng1dev
Copy link

mng1dev commented May 3, 2024

Hello,

I am trying to use the operator and I am installing it via helm chart.

I am passing the following values.yaml file, but it doesn't seem to affect the default properties of the flagd sidecar.

Am I doing anything wrong?

sidecarConfiguration:
  resources:
    requests:
      cpu: 10m
      memory: 16M
    limits:
      cpu: 50m
      memory: 32M
@toddbaert toddbaert self-assigned this May 14, 2024
@toddbaert
Copy link
Member

USER-SUPPLIED VALUES:
sidecarConfiguration:
  port: 8078
  resources:
    limits:
      memory: 72M

COMPUTED VALUES:
controllerManager:
...
  resources:
    limits:
      memory: 72M
...

The helm template seems to be working, but the flagd sidecar doesn't seem to use these resources. The other customizations from the sidecarConfiguration seem to work (port, etc), so I think there's a bug here. I'm still investigating.

@toddbaert toddbaert added the bug Something isn't working label May 14, 2024
@toddbaert
Copy link
Member

toddbaert commented May 15, 2024

Thanks again @mng1dev . This is fixed with #639 and will be released soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants