Skip to content

Commit 3727b13

Browse files
authored
ci: various fixes for linting (#81)
* style: import dd-trace hook before use in _autoload.php Signed-off-by: Tom Carrio <[email protected]> * style: import before use in otel _autoload.php Signed-off-by: Tom Carrio <[email protected]> * refactor: support logger in SplitProvider Signed-off-by: Tom Carrio <[email protected]> * test: return using stringable magic method FlagdProviderTest.php Signed-off-by: Tom Carrio <[email protected]> --------- Signed-off-by: Tom Carrio <[email protected]>
1 parent bb18c04 commit 3727b13

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

hooks/DDTrace/src/_autoload.php

+3-1
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,7 @@
22

33
declare(strict_types=1);
44

5+
use OpenFeature\Hooks\DDTrace\DDTraceHook;
6+
57
// automatically registers the DDTraceHook for OpenFeature
6-
OpenFeature\Hooks\DDTrace\DDTraceHook::register();
8+
DDTraceHook::register();

hooks/OpenTelemetry/src/_autoload.php

+3-1
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,7 @@
22

33
declare(strict_types=1);
44

5+
use OpenFeature\Hooks\OpenTelemetry\OpenTelemetryHook;
6+
57
// automatically registers the OTel hook for OpenFeature
6-
OpenFeature\Hooks\OpenTelemetry\OpenTelemetryHook::register();
8+
OpenTelemetryHook::register();

providers/Flagd/tests/unit/FlagdProviderTest.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public function testCanInstantiateHttpWithConfigObject(): void
5757
$mockStreamFactory->shouldReceive('createStream')->andReturn($mockStream);
5858

5959
$mockResponse = $this->mockery(ResponseInterface::class);
60-
$mockResponse->shouldReceive('getBody')->andReturn("{
60+
$mockResponse->shouldReceive('getBody->__toString')->andReturn("{
6161
\"value\":\"{$expectedValue}\",
6262
\"variant\":\"{$expectedVariant}\",
6363
\"reason\":\"{$expectedReason}\"
@@ -111,7 +111,7 @@ public function testCanInstantiateHttpWithConfigArray(): void
111111
$mockStreamFactory->shouldReceive('createStream')->andReturn($mockStream);
112112

113113
$mockResponse = $this->mockery(ResponseInterface::class);
114-
$mockResponse->shouldReceive('getBody')->andReturn("{
114+
$mockResponse->shouldReceive('getBody->__toString')->andReturn("{
115115
\"value\":\"{$expectedValue}\",
116116
\"variant\":\"{$expectedVariant}\",
117117
\"reason\":\"{$expectedReason}\"

providers/Split/src/SplitProvider.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public function __construct(?string $apiKey = '', array $options = [])
7070
$this->client = $factory->client();
7171
}
7272

73-
public function setLogger(LoggerInterface $logger)
73+
public function setLogger(LoggerInterface $logger): void
7474
{
7575
Di::setLogger($logger);
7676
}

0 commit comments

Comments
 (0)