(test) added resolveBooleanValue tests to FlagsmithProvider

Author: ChrisLightfootWild

providers/Flagsmith/tests/Fixtures/environments/boolean.json

@@ -0,0 +1,67 @@
+{
+  "project": {
+    "name": "Test project",
+    "organisation": {
+      "feature_analytics": false,
+      "name": "Test Org",
+      "id": 1,
+      "persist_trait_data": true,
+      "stop_serving_flags": false
+    },
+    "id": 1,
+    "hide_disabled_flags": false
+  },
+  "segment_overrides": [],
+  "id": 1,
+  "feature_states": [
+    {
+      "multivariate_feature_state_values": [],
+      "feature_state_value": "some-value",
+      "id": 1,
+      "feature": {
+        "name": "some_feature",
+        "type": "STANDARD",
+        "id": 1
+      },
+      "segment_id": null,
+      "enabled": true
+    },
+    {
+      "multivariate_feature_state_values": [],
+      "feature_state_value": "some-value",
+      "id": 1,
+      "feature": {
+        "name": "disabled_feature",
+        "type": "STANDARD",
+        "id": 1
+      },
+      "segment_id": null,
+      "enabled": false
+    }
+  ],
+  "identity_overrides": [
+    {
+      "identifier": "overridden-id",
+      "identity_uuid": "0f21cde8-63c5-4e50-baca-87897fa6cd01",
+      "created_date": "2019-08-27T14:53:45.698555Z",
+      "updated_at": "2023-07-14 16:12:00.000000",
+      "environment_api_key": "B62qaMZNwfiqT76p38ggrQ",
+      "identity_features": [
+        {
+          "id": 1,
+          "feature": {
+            "id": 1,
+            "name": "some_feature",
+            "type": "STANDARD"
+          },
+          "featurestate_uuid": "1bddb9a5-7e59-42c6-9be9-625fa369749f",
+          "feature_state_value": "some-overridden-value",
+          "enabled": false,
+          "environment": 1,
+          "identity": null,
+          "feature_segment": null
+        }
+      ]
+    }
+  ]
+}

providers/Flagsmith/tests/Unit/FlagsmithProviderTest.php

@@ -4,24 +4,78 @@
 
 namespace OpenFeature\Providers\Flagsmith\Test\Unit;
 
+use Flagsmith\Engine\Environments\EnvironmentModel;
 use Flagsmith\Flagsmith;
 use OpenFeature\Providers\Flagsmith\FlagsmithProvider;
 use OpenFeature\Providers\Flagsmith\Test\Fixtures\TestOfflineHandler;
 use OpenFeature\Providers\Flagsmith\Test\TestCase;
+use OpenFeature\interfaces\provider\ErrorCode;
 use OpenFeature\interfaces\provider\Provider;
 
+use function file_get_contents;
+use function json_decode;
+
 class FlagsmithProviderTest extends TestCase
 {
+    protected function buildProvider(string $environmentModelPath): Provider
+    {
+        /** @var string $encoded */
+        $encoded = file_get_contents($environmentModelPath);
+        $modelData = json_decode($encoded,);
+
+        // @phpstan-ignore-next-line EnvironmentModel::build() type-hint is string but implementation expects object
+        $offlineHandler = new TestOfflineHandler(EnvironmentModel::build($modelData));
+        $flagsmith = new Flagsmith('dummy-key', offlineMode: true, offlineHandler: $offlineHandler);
+
+        return new FlagsmithProvider($flagsmith);
+    }
+
     public function testCanBeInstantiated(): void
     {
         // Given
         $flagsmith = new Flagsmith('dummy-key', offlineMode: true, offlineHandler: new TestOfflineHandler());
 
         // When
-        $instance = new FlagsmithProvider($flagsmith);
+        $provider = new FlagsmithProvider($flagsmith);
+
+        // Then
+        $this->assertInstanceOf(Provider::class, $provider);
+    }
+
+    public function testBooleanResolutionWithEnabledFlag(): void
+    {
+        // Given
+        $provider = $this->buildProvider(__DIR__ . '/../Fixtures/environments/boolean.json');
+
+        // When
+        $resolutionDetails = $provider->resolveBooleanValue('some_feature', false);
+
+        // Then
+        $this->assertTrue($resolutionDetails->getValue());
+    }
+
+    public function testBooleanResolutionWithDisabledFlag(): void
+    {
+        // Given
+        $provider = $this->buildProvider(__DIR__ . '/../Fixtures/environments/boolean.json');
+
+        // When
+        $resolutionDetails = $provider->resolveBooleanValue('disabled_feature', true);
+
+        // Then
+        $this->assertFalse($resolutionDetails->getValue());
+    }
+
+    public function testBooleanResolutionWithDefaultValueFromFlag(): void
+    {
+        // Given
+        $provider = $this->buildProvider(__DIR__ . '/../Fixtures/environments/boolean.json');
+
+        // When
+        $resolutionDetails = $provider->resolveBooleanValue('missing_feature', false);
 
         // Then
-        $this->assertNotNull($instance);
-        $this->assertInstanceOf(Provider::class, $instance);
+        $this->assertFalse($resolutionDetails->getValue());
+        $this->assertEquals(ErrorCode::GENERAL(), $resolutionDetails->getError()?->getResolutionErrorCode());
     }
 }