(test) added resolveObjectValue tests to FlagsmithProvider

Signed-off-by: Chris Lightfoot-Wild <[email protected]>

Author: ChrisLightfootWild

providers/Flagsmith/src/FlagsmithProvider.php

@@ -20,6 +20,7 @@
 use OpenFeature\interfaces\provider\Reason;
 use OpenFeature\interfaces\provider\ResolutionDetails;
 
+use function array_is_list;
 use function is_array;
 use function is_null;
 use function is_string;
@@ -79,7 +80,7 @@ public function resolveObjectValue(string $flagKey, mixed $defaultValue, ?Evalua
             }
 
             // Valid JSON document might not be an array, so error in this case.
-            if (!is_array($value)) {
+            if (!is_array($value) || array_is_list($value)) {
                 throw new InvalidArgumentException("Flag [$flagKey] value must be a JSON encoded array");
             }
 

providers/Flagsmith/tests/Fixtures/environments/object.json

@@ -0,0 +1,79 @@
+{
+  "project": {
+    "name": "Test project",
+    "organisation": {
+      "feature_analytics": false,
+      "name": "Test Org",
+      "id": 1,
+      "persist_trait_data": true,
+      "stop_serving_flags": false
+    },
+    "id": 1,
+    "hide_disabled_flags": false
+  },
+  "segment_overrides": [],
+  "id": 1,
+  "feature_states": [
+    {
+      "multivariate_feature_state_values": [],
+      "feature_state_value": "{\"key\":\"value\"}",
+      "id": 1,
+      "feature": {
+        "name": "object_feature",
+        "type": "STANDARD",
+        "id": 1
+      },
+      "segment_id": null,
+      "enabled": true
+    },
+    {
+      "multivariate_feature_state_values": [],
+      "feature_state_value": "some-value",
+      "id": 1,
+      "feature": {
+        "name": "disabled_object_feature",
+        "type": "STANDARD",
+        "id": 1
+      },
+      "segment_id": null,
+      "enabled": false
+    },
+    {
+      "multivariate_feature_state_values": [],
+      "feature_state_value": "[\"foo\",\"bar\"]",
+      "id": 1,
+      "feature": {
+        "name": "invalid_object_feature",
+        "type": "STANDARD",
+        "id": 1
+      },
+      "segment_id": null,
+      "enabled": true
+    }
+  ],
+  "identity_overrides": [
+    {
+      "identifier": "overridden-id",
+      "identity_uuid": "0f21cde8-63c5-4e50-baca-87897fa6cd01",
+      "created_date": "2019-08-27T14:53:45.698555Z",
+      "updated_at": "2023-07-14 16:12:00.000000",
+      "environment_api_key": "B62qaMZNwfiqT76p38ggrQ",
+      "identity_features": [
+        {
+          "id": 1,
+          "feature": {
+            "id": 1,
+            "name": "some_feature",
+            "type": "STANDARD"
+          },
+          "featurestate_uuid": "1bddb9a5-7e59-42c6-9be9-625fa369749f",
+          "feature_state_value": "some-overridden-value",
+          "enabled": false,
+          "environment": 1,
+          "identity": null,
+          "feature_segment": null
+        }
+      ]
+    }
+  ]
+}

providers/Flagsmith/tests/Unit/FlagsmithProviderTest.php

@@ -193,4 +193,52 @@ public function testFloatResolutionWithMissingFlag(): void
         $this->assertEquals(ErrorCode::GENERAL(), $resolutionDetails->getError()?->getResolutionErrorCode());
         $this->assertEquals(Reason::ERROR, $resolutionDetails->getReason());
     }
+
+    public function testObjectResolutionWithEnabledFlag(): void
+    {
+        // Given
+        $provider = $this->buildProvider(__DIR__ . '/../Fixtures/environments/object.json');
+
+        // When
+        $resolutionDetails = $provider->resolveObjectValue('object_feature', ['a' => 'b']);
+
+        // Then
+        $this->assertEquals(['key' => 'value'], $resolutionDetails->getValue());
+    }
+
+    public function testObjectResolutionWithDisabledFlag(): void
+    {
+        // Given
+        $provider = $this->buildProvider(__DIR__ . '/../Fixtures/environments/object.json');
+
+        // When
+        $resolutionDetails = $provider->resolveObjectValue('disabled_object_feature', ['a' => 'b']);
+
+        // Then
+        $this->assertEquals(['a' => 'b'], $resolutionDetails->getValue());
+    }
+
+    public function testObjectResolutionWithMissingFlag(): void
+    {
+        // Given
+        $provider = $this->buildProvider(__DIR__ . '/../Fixtures/environments/object.json');
+
+        // When
+        $resolutionDetails = $provider->resolveObjectValue('missing_object_feature', ['c' => 3, 'p' => 'o']);
+
+        // Then
+        $this->assertEquals(['c' => 3, 'p' => 'o'], $resolutionDetails->getValue());
+    }
+
+    public function testObjectResolutionWithEnabledFlagWithInvalidValue(): void
+    {
+        // Given
+        $provider = $this->buildProvider(__DIR__ . '/../Fixtures/environments/object.json');
+
+        // When
+        $resolutionDetails = $provider->resolveObjectValue('invalid_object_feature', ['default' => 'value']);
+
+        // Then
+        $this->assertEquals(['default' => 'value'], $resolutionDetails->getValue());
+    }
 }