feat: otel hook #22
Merged
feat: otel hook #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcarrio
force-pushed
the
feat/otel-hook
branch
3 times, most recently
from
2320b84 to
43b0783
Compare
- new statically registerable OTel hook for OpenFeature - move hooks and providers into independent directories - enable PHP 8.2 runner - disable integration tests since none exist - utilize test wrapper script definition in CI Ref: #6 Signed-off-by: Tom Carrio <[email protected]> Signed-off-by: Tom Carrio <[email protected]>
tcarrio
force-pushed
the
feat/otel-hook
branch
from
43b0783 to
c293fc3
Compare
Signed-off-by: Tom Carrio <[email protected]>
Signed-off-by: Tom Carrio <[email protected]>
Signed-off-by: Tom Carrio <[email protected]>
|
I approve? 🤷 |
This was referenced Jan 9, 2023
Closed
Closed
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #6
Notes
Follow-up Tasks
More tests. The PHP OTel API exposes a null-safe means to access the current span that absolutely cannot fail, so this is very low risk. Either way, I'll be mocking the call to ensure everything is run through correctly.
How to test
Execute (in-progress) tests.