fix/unit-tests: Remove invalid flag type check in private method _create_provider_evaluation

Signed-off-by: Andrew Helsby <[email protected]>

Signed-off-by: Andrew Helsby <[email protected]>

Author: ajhelsby

open_feature/open_feature_client.py

@@ -3,7 +3,7 @@
 from numbers import Number
 
 from open_feature.evaluation_context.evaluation_context import EvaluationContext
-from open_feature.exception.exceptions import GeneralError, OpenFeatureError
+from open_feature.exception.exceptions import OpenFeatureError
 from open_feature.flag_evaluation.error_code import ErrorCode
 from open_feature.flag_evaluation.flag_evaluation_details import FlagEvaluationDetails
 from open_feature.flag_evaluation.flag_type import FlagType
@@ -274,9 +274,6 @@ def _create_provider_evaluation(
             FlagType.NUMBER: self.provider.get_number_details,
             FlagType.OBJECT: self.provider.get_object_details,
             FlagType.STRING: self.provider.get_string_details,
-        }.get(flag_type)
-
-        if not get_details_callable:
-            raise GeneralError(error_message="Unknown flag type")
+        }[flag_type]
 
         return get_details_callable(*args)

tests/test_open_feature_client.py

@@ -3,11 +3,10 @@
 
 import pytest
 
-from open_feature.exception.exceptions import GeneralError, OpenFeatureError
+from open_feature.exception.exceptions import OpenFeatureError
 from open_feature.flag_evaluation.error_code import ErrorCode
 from open_feature.flag_evaluation.reason import Reason
 from open_feature.hooks.hook import Hook
-from open_feature.open_feature_client import OpenFeatureClient
 
 
 @pytest.mark.parametrize(
@@ -72,19 +71,6 @@ def test_should_get_flag_detail_based_on_method_type(
     assert isinstance(flag.value, flag_type)
 
 
-def test_should_raise_exception_when_invalid_flag_type_provided():
-    # Given
-    # When
-    with pytest.raises(GeneralError) as ge:
-        OpenFeatureClient("No provider", "1.0")._create_provider_evaluation(
-            flag_type=None, flag_key="Key", default_value=True
-        )
-    # Then
-    assert ge.value
-    assert ge.value.error_message == "Unknown flag type"
-    assert ge.value.error_code == ErrorCode.GENERAL
-
-
 def test_should_handle_a_generic_exception_thrown_by_a_provider(no_op_provider_client):
     # Given
     exception_hook = MagicMock(spec=Hook)