-
Notifications
You must be signed in to change notification settings - Fork 23
feat: Add release please to handle releases #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Andrew Helsby <[email protected]> Signed-off-by: Andrew Helsby <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to consider adding a release-please-config.json
to the root of the project. You can reuse most of the settings found here. You'll just need to change the release type and bootstrap sha.
Finally, you can use release please to bump versions in the readme. You just need to add them to the config like this and add comments to the files that need to have a version bumped on release. You can see an example here.
Please let me know if you have any questions.
Signed-off-by: Andrew Helsby <[email protected]> Signed-off-by: Andrew Helsby <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #45 +/- ##
==========================================
- Coverage 93.59% 92.83% -0.76%
==========================================
Files 17 18 +1
Lines 281 321 +40
==========================================
+ Hits 263 298 +35
- Misses 18 23 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…ease please Signed-off-by: Andrew Helsby <[email protected]> Signed-off-by: Andrew Helsby <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should work. The last part missing is the release please comments in the readme. You can see an example here. This part is required or it won't automatically bump the version in the readme as part of the release process.
It's also worth mentioning that Release Please works off semantic commits. Most of the repos use a PR title validator and perform squash merges. I'm happy to help set that up if you're interested. |
I believe this has already been set up here https://github.com/open-feature/python-sdk/blob/main/.github/workflows/lint-pr.yml |
Signed-off-by: Andrew Helsby <[email protected]> Signed-off-by: Andrew Helsby <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well, but these things usually take some troubleshooting 🤞
This PR
Add the release please action to handle release versioning
Related Issues
Notes
Follow-up Tasks
How to test