Rename eventing protocols

Signed-off-by: Fabrizio Demaria <[email protected]>

Author: fabriziodemaria

README.md

@@ -91,7 +91,7 @@ let client = OpenFeatureAPI.shared.getClient()
 let flagValue = client.getBooleanValue(key: "boolFlag", defaultValue: false)
 ```
 
-Setting a new provider or setting a new evaluation context might trigger asynchronous operations (e.g. fetching flag evaluations from the backend and store them in a local cache). It's advised to not interact with the OpenFeature client until the `ProviderReady` event has been emitted (see [Eventing](#eventing) below).
+Setting a new provider or setting a new evaluation context might trigger asynchronous operations (e.g. fetching flag evaluations from the backend and store them in a local cache). It's advised to not interact with the OpenFeature client until the `ProviderReady` event has been sent (see [Eventing](#eventing) below).
 
 ## 🌟 Features
 

Sources/OpenFeature/EventHandler.swift

@@ -1,7 +1,7 @@
 import Foundation
 import Combine
 
-public class EventHandler: EventEmitter, EventPublisher {
+public class EventHandler: EventSender, EventObserver {
     private let subject: CurrentValueSubject<ProviderEvent, Never>
 
     public init(_ state: ProviderEvent) {
@@ -12,17 +12,17 @@ public class EventHandler: EventEmitter, EventPublisher {
         return subject
     }
 
-    public func emit(
+    public func send(
         _ event: ProviderEvent
     ) {
         subject.send(event)
     }
 }
 
-public protocol EventPublisher {
+public protocol EventObserver {
     func observe() -> CurrentValueSubject<ProviderEvent, Never>
 }
 
-public protocol EventEmitter {
-    func emit(_ event: ProviderEvent)
+public protocol EventSender {
+    func send(_ event: ProviderEvent)
 }

Sources/OpenFeature/OpenFeatureAPI.swift

@@ -3,7 +3,7 @@ import Combine
 
 /// A global singleton which holds base configuration for the OpenFeature library.
 /// Configuration here will be shared across all ``Client``s.
-public class OpenFeatureAPI: EventPublisher {
+public class OpenFeatureAPI: EventObserver {
     private var _provider: FeatureProvider?
     private var _context: EvaluationContext?
     private(set) var hooks: [any Hook] = []

Sources/OpenFeature/Provider/FeatureProvider.swift

@@ -1,7 +1,7 @@
 import Foundation
 
 /// The interface implemented by upstream flag providers to resolve flags for their service.
-public protocol FeatureProvider: EventPublisher {
+public protocol FeatureProvider: EventObserver {
     var hooks: [any Hook] { get }
     var metadata: ProviderMetadata { get }
 

Sources/OpenFeature/Provider/NoOpProvider.swift

@@ -15,11 +15,11 @@ class NoOpProvider: FeatureProvider {
     var hooks: [any Hook] = []
 
     func onContextSet(oldContext: EvaluationContext?, newContext: EvaluationContext) {
-        eventHandler.emit(.configurationChanged)
+        eventHandler.send(.configurationChanged)
     }
 
     func initialize(initialContext: EvaluationContext?) {
-        eventHandler.emit(.ready)
+        eventHandler.send(.ready)
     }
 
     func getBooleanEvaluation(key: String, defaultValue: Bool, context: EvaluationContext?) throws

Tests/OpenFeatureTests/Helpers/AlwaysBrokenProvider.swift

@@ -9,13 +9,11 @@ class AlwaysBrokenProvider: FeatureProvider {
     private let eventHandler = EventHandler(.stale)
 
     func onContextSet(oldContext: OpenFeature.EvaluationContext?, newContext: OpenFeature.EvaluationContext) {
-        let error = OpenFeatureError.generalError(message: "Always Fails")
-        eventHandler.emit(.error)
+        eventHandler.send(.error)
     }
 
     func initialize(initialContext: OpenFeature.EvaluationContext?) {
-        let error = OpenFeatureError.generalError(message: "Always Fails")
-        eventHandler.emit(.error)
+        eventHandler.send(.error)
     }
 
     func getBooleanEvaluation(key: String, defaultValue: Bool, context: EvaluationContext?) throws

Tests/OpenFeatureTests/Helpers/DoSomethingProvider.swift

@@ -8,11 +8,11 @@ class DoSomethingProvider: FeatureProvider {
     private var holdit: AnyCancellable?
 
     func onContextSet(oldContext: OpenFeature.EvaluationContext?, newContext: OpenFeature.EvaluationContext) {
-        eventHandler.emit(.configurationChanged)
+        eventHandler.send(.configurationChanged)
     }
 
     func initialize(initialContext: OpenFeature.EvaluationContext?) {
-        eventHandler.emit(.ready)
+        eventHandler.send(.ready)
     }
 
     var hooks: [any OpenFeature.Hook] = []

Tests/OpenFeatureTests/ProviderEventsTests.swift

@@ -6,7 +6,7 @@ final class ProviderEventsTests: XCTestCase {
     let provider = DoSomethingProvider()
     let readyExpectation = XCTestExpectation(description: "Ready")
 
-    func testReadyEventEmitted() {
+    func testReadyEventSent() {
         let sink = provider
             .observe()
             .filter { event in