feat: Add setProviderAndWait #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziodemaria
force-pushed
the
set-and-wait
branch
2 times, most recently
from
4176983 to
1c49908
Compare
fabriziodemaria
changed the title
fabriziodemaria
force-pushed
the
set-and-wait
branch
2 times, most recently
from
072864e to
12ad983
Compare
fabriziodemaria
commented
Jan 22, 2024
vahidlazio
force-pushed
the
event-handler
branch
7 times, most recently
from
61ddf6f to
1efff09
Compare
fabriziodemaria
force-pushed
the
event-handler
branch
from
bfeecad to
2ae4cb9
Compare
fabriziodemaria
force-pushed
the
set-and-wait
branch
2 times, most recently
from
c7c903b to
8cbdedb
Compare
fabriziodemaria
force-pushed
the
set-and-wait
branch
3 times, most recently
from
90a74aa to
6732b91
Compare
fabriziodemaria
force-pushed
the
set-and-wait
branch
from
6732b91 to
bf5057e
Compare
fabriziodemaria
commented
Jan 25, 2024
fabriziodemaria
commented
Jan 25, 2024
fabriziodemaria
force-pushed
the
set-and-wait
branch
from
856a66b to
3d48f7c
Compare
fabriziodemaria
commented
Jan 25, 2024
fabriziodemaria
force-pushed
the
set-and-wait
branch
3 times, most recently
from
b9a3a67 to
7b118f1
Compare
Signed-off-by: Fabrizio Demaria <[email protected]> Signed-off-by: Fabrizio Demaria <[email protected]>
Signed-off-by: Fabrizio Demaria <[email protected]>
Signed-off-by: Fabrizio Demaria <[email protected]>
fabriziodemaria
force-pushed
the
set-and-wait
branch
2 times, most recently
from
0f8dfd3 to
e691284
Compare
Signed-off-by: Fabrizio Demaria <[email protected]>
Signed-off-by: Fabrizio Demaria <[email protected]>
fabriziodemaria
force-pushed
the
set-and-wait
branch
from
e691284 to
a781e42
Compare
vahidlazio
reviewed
Jan 29, 2024
vahidlazio
approved these changes
Jan 29, 2024
fabriziodemaria
pushed a commit
that referenced
this pull request
Feb 2, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.0](0.0.2...0.1.0) (2024-02-02) ### ⚠ BREAKING CHANGES * Add EventHandler + Combine ([#29](#29)) ### 🐛 Bug Fixes * setProviderAndWait does not hang on ProviderError ([#35](#35)) ([5661080](5661080)) ### ✨ New Features * Add ProviderNotReady event ([#36](#36)) ([389f117](389f117)) * Add setProviderAndWait ([#30](#30)) ([3ce6b8d](3ce6b8d)) ### 🧹 Chore * **deps:** update actions/checkout action to v4 ([#18](#18)) ([eb0cd56](eb0cd56)) * **deps:** update dependency apple/swift-format to v509 ([#21](#21)) ([5f12304](5f12304)) * Smaller cleanup in tests ([#33](#33)) ([053dabc](053dabc)) ### 📚 Documentation * add sections for logging, named providers, and shutdown ([#31](#31)) ([dc5876c](dc5876c)) * Fix Installation documentation ([#27](#27)) ([5ddf45d](5ddf45d)), closes [#25](#25) * Update README to latest template ([#28](#28)) ([dbdd502](dbdd502)) * Update README.md ([#19](#19)) ([ec599ff](ec599ff)) ### 🔄 Refactoring * Add EventHandler + Combine ([#29](#29)) ([dd122f7](dd122f7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
setProviderAndWaitextension function, exposed by this library as a user-facing API (documentation also updated).The application can now use
async/awaitto wait for the Provider to be ready, before reading flags. The older alternative (still available) is for the application to callsetProviderand listen for.readyevent manually.