Implement review feedback

Author: CAD97

unic/utils/src/lib.rs

@@ -7,7 +7,6 @@
 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
-//! Utilities for use in UNIC development.
 
 
 #![forbid(missing_docs)]

unic/utils/src/macros.rs

@@ -22,10 +22,10 @@
 ///     }
 ///
 ///     /// Zero or more attributes
-///     pub mod abbr_names;
+///     pub mod abbr_names for abbr;
 ///
 ///     /// Zero or more attributes
-///     pub mod long_names;
+///     pub mod long_names for long;
 /// }
 ///
 /// // You must impl (Partial/Complete)CharProperty manually.
@@ -67,8 +67,8 @@ macro_rules! char_property {
             $( $(#[$variant_meta:meta])+ $variant:ident $tt:tt )*
         }
 
-        $(#[$abbr_names_meta:meta])* pub mod $abbr_names:ident;
-        $(#[$long_names_meta:meta])* pub mod $long_names:ident;
+        $(#[$abbr_names_meta:meta])* pub mod $abbr_names:ident for abbr;
+        $(#[$long_names_meta:meta])* pub mod $long_names:ident for long;
     ) => {
         __char_property_internal! {
             $(#[$name_meta])* pub enum $name
@@ -320,7 +320,6 @@ macro_rules! __char_property_internal {
         }
 
         #[allow(bad_style)]
-        #[allow(unreachable_patterns)]
         impl $crate::char_property::EnumeratedCharProperty for $name {
             fn abbr_name(&self) -> &'static str {
                 match *self {

unic/utils/tests/macro_tests.rs

@@ -17,16 +17,16 @@ char_property! {
         /// Required
         DisplayVariant {
             abbr => DV,
-            display => "The one and only DISPLAY VARIANT!!!11!",
+            display => "The one and only DISPLAY VARIANT!",
         }
         /// Required
         EmptyVariant {
             abbr => EV,
         }
     }
 
-    pub mod abbr_names;
-    pub mod long_names;
+    pub mod abbr_names for abbr;
+    pub mod long_names for long;
 }
 
 impl unic_utils::char_property::PartialCharProperty for Property {
@@ -51,6 +51,6 @@ fn basic_macro_use() {
 
     assert_eq!(format!("{}", Property::AbbrVariant), "AV");
     assert_eq!(format!("{}", Property::LongVariant), "Long Variant");
-    assert_eq!(format!("{}", Property::DisplayVariant), "The one and only DISPLAY VARIANT!!!11!");
+    assert_eq!(format!("{}", Property::DisplayVariant), "The one and only DISPLAY VARIANT!");
     assert_eq!(format!("{}", Property::EmptyVariant), "EV");
 }