ValueIterator operators * and -> need to be const

Author: BillyDonahue

Diff for: include/json/value.h

@@ -918,8 +918,8 @@ class JSON_API ValueIterator : public ValueIteratorBase {
    *  because the returned references/pointers can be used
    *  to change state of the base class.
    */
-  reference operator*() { return deref(); }
-  pointer operator->() { return &deref(); }
+  reference operator*() const { return const_cast<reference>(deref()); }
+  pointer operator->() const { return const_cast<pointer>(&deref()); }
 };
 
 inline void swap(Value& a, Value& b) { a.swap(b); }

Diff for: src/test_lib_json/main.cpp

@@ -3724,7 +3724,7 @@ JSONTEST_FIXTURE_LOCAL(IteratorTest, reverseIterator) {
   using Iter = decltype(json.begin());
   auto re = std::reverse_iterator<Iter>(json.begin());
   for (auto it = std::reverse_iterator<Iter>(json.end()); it != re; ++it) {
-    values.push_back((*it).asString());
+    values.push_back(it->asString());
   }
   JSONTEST_ASSERT((values == std::vector<std::string>{"b", "a"}));
 }