Skip to content

Commit ad9d38d

Browse files
authored
Apply suggestions from code review
1 parent e464d64 commit ad9d38d

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

docs/maintaining-dependencies.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -433,7 +433,7 @@ Update the `sha256`.
433433

434434
## Upgrade a git submodule
435435

436-
All the git submodule is under the folder `third_party`.
436+
All the git submodule are under the folder `third_party`.
437437
We will use `opentelemetry-propto` as example in this case.
438438
This is a `git submodule`, it needs to point to the new tag.
439439

@@ -454,7 +454,7 @@ Date: Thu Apr 25 17:55:35 2024 +0200
454454
generate profiles proto for CI (#552)
455455
```
456456
457-
In this case we could know the current tag is `v.1.3.1`.
457+
In this case we can see the current tag is `v.1.3.1`.
458458
459459
### Upgrade to new tag
460460
@@ -513,7 +513,7 @@ git add third_party/opentelemetry-proto
513513
514514
Same as git submodule, we will continue use `opentelemetry-proto` as example.
515515
516-
All the bazel dependencies is defined in [repository.bzl](https://github.com/open-telemetry/opentelemetry-cpp/blob/main/bazel/repository.bzl)
516+
All the bazel dependencies are defined in [repository.bzl](https://github.com/open-telemetry/opentelemetry-cpp/blob/main/bazel/repository.bzl)
517517
and [MODULE.bazel](https://github.com/open-telemetry/opentelemetry-cpp/blob/main/MODULE.bazel).
518518
519519
### Update the dependency in repository.bzl

0 commit comments

Comments
 (0)