@@ -322,10 +322,12 @@ TEST_P(WritableMetricStorageHistogramTestFixture, DoubleHistogram)
322
322
});
323
323
EXPECT_EQ (count_attributes, 2 ); // GET and PUT
324
324
}
325
+
325
326
INSTANTIATE_TEST_SUITE_P (WritableMetricStorageHistogramTestDouble,
326
- WritableMetricStorageHistogramTestFixture,
327
- ::testing::Values (AggregationTemporality::kCumulative ,
328
- AggregationTemporality::kDelta ));
327
+ WritableMetricStorageHistogramTestFixture,
328
+ ::testing::Values (AggregationTemporality::kCumulative ,
329
+ AggregationTemporality::kDelta ));
330
+
329
331
TEST_P (WritableMetricStorageHistogramTestFixture, Base2ExponentialDoubleHistogram)
330
332
{
331
333
AggregationTemporality temporality = GetParam ();
@@ -377,17 +379,28 @@ TEST_P(WritableMetricStorageHistogramTestFixture, Base2ExponentialDoubleHistogra
377
379
collector.get (), collectors, sdk_start_ts, collection_ts, [&](const MetricData &metric_data) {
378
380
for (const auto &data_attr : metric_data.point_data_attr_ )
379
381
{
380
- const auto &data = opentelemetry::nostd::get<Base2ExponentialHistogramPointData>(data_attr.point_data );
382
+ const auto &data =
383
+ opentelemetry::nostd::get<Base2ExponentialHistogramPointData>(data_attr.point_data );
381
384
if (opentelemetry::nostd::get<std::string>(
382
385
data_attr.attributes .find (" RequestType" )->second ) == " GET" )
383
386
{
384
387
EXPECT_EQ (data.sum_ , expected_total_get_requests);
388
+ EXPECT_EQ (data.count_ , 2 );
389
+ EXPECT_EQ (data.min_ , 10 );
390
+ EXPECT_EQ (data.max_ , 20 );
391
+ EXPECT_EQ (data.positive_buckets_ .Empty (), false );
392
+ EXPECT_EQ (data.negative_buckets_ .Empty (), true );
385
393
count_attributes++;
386
394
}
387
395
else if (opentelemetry::nostd::get<std::string>(
388
396
data_attr.attributes .find (" RequestType" )->second ) == " PUT" )
389
397
{
390
398
EXPECT_EQ (data.sum_ , expected_total_put_requests);
399
+ EXPECT_EQ (data.count_ , 2 );
400
+ EXPECT_EQ (data.min_ , 30 );
401
+ EXPECT_EQ (data.max_ , 40 );
402
+ EXPECT_EQ (data.positive_buckets_ .Empty (), false );
403
+ EXPECT_EQ (data.negative_buckets_ .Empty (), true );
391
404
count_attributes++;
392
405
}
393
406
}
@@ -414,7 +427,8 @@ TEST_P(WritableMetricStorageHistogramTestFixture, Base2ExponentialDoubleHistogra
414
427
}
415
428
for (const auto &data_attr : metric_data.point_data_attr_ )
416
429
{
417
- const auto &data = opentelemetry::nostd::get<Base2ExponentialHistogramPointData>(data_attr.point_data );
430
+ const auto &data =
431
+ opentelemetry::nostd::get<Base2ExponentialHistogramPointData>(data_attr.point_data );
418
432
if (opentelemetry::nostd::get<std::string>(
419
433
data_attr.attributes .find (" RequestType" )->second ) == " GET" )
420
434
{
@@ -450,7 +464,8 @@ TEST_P(WritableMetricStorageHistogramTestFixture, Base2ExponentialDoubleHistogra
450
464
collector.get (), collectors, sdk_start_ts, collection_ts, [&](const MetricData &metric_data) {
451
465
for (const auto &data_attr : metric_data.point_data_attr_ )
452
466
{
453
- const auto &data = opentelemetry::nostd::get<Base2ExponentialHistogramPointData>(data_attr.point_data );
467
+ const auto &data =
468
+ opentelemetry::nostd::get<Base2ExponentialHistogramPointData>(data_attr.point_data );
454
469
if (opentelemetry::nostd::get<std::string>(
455
470
data_attr.attributes .find (" RequestType" )->second ) == " GET" )
456
471
{
0 commit comments