Skip to content

Commit b9e5df6

Browse files
committed
add prelim bucketing checks
1 parent 84c09d1 commit b9e5df6

File tree

1 file changed

+21
-6
lines changed

1 file changed

+21
-6
lines changed

sdk/test/metrics/sync_metric_storage_histogram_test.cc

+21-6
Original file line numberDiff line numberDiff line change
@@ -322,10 +322,12 @@ TEST_P(WritableMetricStorageHistogramTestFixture, DoubleHistogram)
322322
});
323323
EXPECT_EQ(count_attributes, 2); // GET and PUT
324324
}
325+
325326
INSTANTIATE_TEST_SUITE_P(WritableMetricStorageHistogramTestDouble,
326-
WritableMetricStorageHistogramTestFixture,
327-
::testing::Values(AggregationTemporality::kCumulative,
328-
AggregationTemporality::kDelta));
327+
WritableMetricStorageHistogramTestFixture,
328+
::testing::Values(AggregationTemporality::kCumulative,
329+
AggregationTemporality::kDelta));
330+
329331
TEST_P(WritableMetricStorageHistogramTestFixture, Base2ExponentialDoubleHistogram)
330332
{
331333
AggregationTemporality temporality = GetParam();
@@ -377,17 +379,28 @@ TEST_P(WritableMetricStorageHistogramTestFixture, Base2ExponentialDoubleHistogra
377379
collector.get(), collectors, sdk_start_ts, collection_ts, [&](const MetricData &metric_data) {
378380
for (const auto &data_attr : metric_data.point_data_attr_)
379381
{
380-
const auto &data = opentelemetry::nostd::get<Base2ExponentialHistogramPointData>(data_attr.point_data);
382+
const auto &data =
383+
opentelemetry::nostd::get<Base2ExponentialHistogramPointData>(data_attr.point_data);
381384
if (opentelemetry::nostd::get<std::string>(
382385
data_attr.attributes.find("RequestType")->second) == "GET")
383386
{
384387
EXPECT_EQ(data.sum_, expected_total_get_requests);
388+
EXPECT_EQ(data.count_, 2);
389+
EXPECT_EQ(data.min_, 10);
390+
EXPECT_EQ(data.max_, 20);
391+
EXPECT_EQ(data.positive_buckets_.Empty(), false);
392+
EXPECT_EQ(data.negative_buckets_.Empty(), true);
385393
count_attributes++;
386394
}
387395
else if (opentelemetry::nostd::get<std::string>(
388396
data_attr.attributes.find("RequestType")->second) == "PUT")
389397
{
390398
EXPECT_EQ(data.sum_, expected_total_put_requests);
399+
EXPECT_EQ(data.count_, 2);
400+
EXPECT_EQ(data.min_, 30);
401+
EXPECT_EQ(data.max_, 40);
402+
EXPECT_EQ(data.positive_buckets_.Empty(), false);
403+
EXPECT_EQ(data.negative_buckets_.Empty(), true);
391404
count_attributes++;
392405
}
393406
}
@@ -414,7 +427,8 @@ TEST_P(WritableMetricStorageHistogramTestFixture, Base2ExponentialDoubleHistogra
414427
}
415428
for (const auto &data_attr : metric_data.point_data_attr_)
416429
{
417-
const auto &data = opentelemetry::nostd::get<Base2ExponentialHistogramPointData>(data_attr.point_data);
430+
const auto &data =
431+
opentelemetry::nostd::get<Base2ExponentialHistogramPointData>(data_attr.point_data);
418432
if (opentelemetry::nostd::get<std::string>(
419433
data_attr.attributes.find("RequestType")->second) == "GET")
420434
{
@@ -450,7 +464,8 @@ TEST_P(WritableMetricStorageHistogramTestFixture, Base2ExponentialDoubleHistogra
450464
collector.get(), collectors, sdk_start_ts, collection_ts, [&](const MetricData &metric_data) {
451465
for (const auto &data_attr : metric_data.point_data_attr_)
452466
{
453-
const auto &data = opentelemetry::nostd::get<Base2ExponentialHistogramPointData>(data_attr.point_data);
467+
const auto &data =
468+
opentelemetry::nostd::get<Base2ExponentialHistogramPointData>(data_attr.point_data);
454469
if (opentelemetry::nostd::get<std::string>(
455470
data_attr.attributes.find("RequestType")->second) == "GET")
456471
{

0 commit comments

Comments
 (0)