Skip to content

Commit c03f724

Browse files
authored
Update to java sdk 1.13.0 (#20)
1 parent 463f92b commit c03f724

File tree

5 files changed

+15
-18
lines changed

5 files changed

+15
-18
lines changed

build.gradle

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ plugins {
44
}
55

66
ext {
7-
openTelemetryVersion = "1.12.0"
8-
openTelemetryAlphaVersion = "1.12.0-alpha"
7+
openTelemetryVersion = "1.13.0"
8+
openTelemetryAlphaVersion = "1.13.0-alpha"
99

1010
grpcVersion = '1.34.1'
1111
protobufVersion = '3.11.4'

logging/src/main/java/io/opentelemetry/example/logging/ExampleConfiguration.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import io.opentelemetry.exporter.logging.LoggingSpanExporter;
66
import io.opentelemetry.sdk.OpenTelemetrySdk;
77
import io.opentelemetry.sdk.metrics.SdkMeterProvider;
8-
import io.opentelemetry.sdk.metrics.export.MetricReaderFactory;
8+
import io.opentelemetry.sdk.metrics.export.MetricReader;
99
import io.opentelemetry.sdk.metrics.export.PeriodicMetricReader;
1010
import io.opentelemetry.sdk.trace.SdkTracerProvider;
1111
import io.opentelemetry.sdk.trace.export.SimpleSpanProcessor;
@@ -26,16 +26,16 @@ public final class ExampleConfiguration {
2626
* @return A ready-to-use {@link OpenTelemetry} instance.
2727
*/
2828
public static OpenTelemetry initOpenTelemetry() {
29-
// Create an instance of PeriodicMetricReaderFactory and configure it
29+
// Create an instance of PeriodicMetricReader and configure it
3030
// to export via the logging exporter
31-
MetricReaderFactory periodicReaderFactory =
31+
MetricReader periodicReader =
3232
PeriodicMetricReader.builder(LoggingMetricExporter.create())
3333
.setInterval(Duration.ofMillis(METRIC_EXPORT_INTERVAL_MS))
34-
.newMetricReaderFactory();
34+
.build();
3535

3636
// This will be used to create instruments
3737
SdkMeterProvider meterProvider =
38-
SdkMeterProvider.builder().registerMetricReader(periodicReaderFactory).build();
38+
SdkMeterProvider.builder().registerMetricReader(periodicReader).build();
3939

4040
// Tracer provider configured to export spans with SimpleSpanProcessor using
4141
// the logging exporter.

otlp/src/main/java/io/opentelemetry/example/otlp/ExampleConfiguration.java

+4-6
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import io.opentelemetry.sdk.OpenTelemetrySdk;
1313
import io.opentelemetry.sdk.autoconfigure.AutoConfiguredOpenTelemetrySdk;
1414
import io.opentelemetry.sdk.metrics.SdkMeterProvider;
15-
import io.opentelemetry.sdk.metrics.export.MetricReaderFactory;
15+
import io.opentelemetry.sdk.metrics.export.MetricReader;
1616
import io.opentelemetry.sdk.metrics.export.PeriodicMetricReader;
1717
import io.opentelemetry.sdk.trace.SdkTracerProvider;
1818
import io.opentelemetry.sdk.trace.export.BatchSpanProcessor;
@@ -64,13 +64,11 @@ static MeterProvider initOpenTelemetryMetrics() {
6464
// set up the metric exporter and wire it into the SDK and a timed periodic reader.
6565
OtlpGrpcMetricExporter metricExporter = OtlpGrpcMetricExporter.getDefault();
6666

67-
MetricReaderFactory periodicReaderFactory =
68-
PeriodicMetricReader.builder(metricExporter)
69-
.setInterval(Duration.ofMillis(1000))
70-
.newMetricReaderFactory();
67+
MetricReader periodicReader =
68+
PeriodicMetricReader.builder(metricExporter).setInterval(Duration.ofMillis(1000)).build();
7169

7270
SdkMeterProvider sdkMeterProvider =
73-
SdkMeterProvider.builder().registerMetricReader(periodicReaderFactory).build();
71+
SdkMeterProvider.builder().registerMetricReader(periodicReader).build();
7472

7573
Runtime.getRuntime().addShutdownHook(new Thread(sdkMeterProvider::shutdown));
7674
return sdkMeterProvider;

prometheus/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ These are collected by a Prometheus instance which is configured to pull these m
1717
```
1818
## 2 - Run Prometheus
1919

20-
Start Prometheus instance with a configuration that sets up a HTTP collection job for ```127.0.0.1:19090```
20+
Start Prometheus instance with a configuration that sets up an HTTP collection job for ```127.0.0.1:19090```
2121

2222
See [prometheus.yml](prometheus.yml)
2323

prometheus/src/main/java/io/opentelemetry/example/prometheus/ExampleConfiguration.java

+3-4
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import io.opentelemetry.api.metrics.MeterProvider;
99
import io.opentelemetry.exporter.prometheus.PrometheusHttpServer;
1010
import io.opentelemetry.sdk.metrics.SdkMeterProvider;
11-
import io.opentelemetry.sdk.metrics.export.MetricReaderFactory;
11+
import io.opentelemetry.sdk.metrics.export.MetricReader;
1212
import java.io.IOException;
1313

1414
public final class ExampleConfiguration {
@@ -20,9 +20,8 @@ public final class ExampleConfiguration {
2020
* @return A MeterProvider for use in instrumentation.
2121
*/
2222
static MeterProvider initializeOpenTelemetry(int prometheusPort) throws IOException {
23-
MetricReaderFactory prometheusReaderFactory =
24-
PrometheusHttpServer.builder().setPort(prometheusPort).newMetricReaderFactory();
23+
MetricReader prometheusReader = PrometheusHttpServer.builder().setPort(prometheusPort).build();
2524

26-
return SdkMeterProvider.builder().registerMetricReader(prometheusReaderFactory).build();
25+
return SdkMeterProvider.builder().registerMetricReader(prometheusReader).build();
2726
}
2827
}

0 commit comments

Comments
 (0)