Skip to content

Commit 1b1d537

Browse files
authored
Reduce warning log about maxExportBatchSize. (#7148)
1 parent 42056f5 commit 1b1d537

File tree

2 files changed

+8
-14
lines changed

2 files changed

+8
-14
lines changed

sdk/logs/src/main/java/io/opentelemetry/sdk/logs/export/BatchLogRecordProcessorBuilder.java

+4-7
Original file line numberDiff line numberDiff line change
@@ -107,9 +107,6 @@ long getExporterTimeoutNanos() {
107107
*/
108108
public BatchLogRecordProcessorBuilder setMaxQueueSize(int maxQueueSize) {
109109
checkArgument(maxQueueSize > 0, "maxQueueSize must be positive.");
110-
if (maxExportBatchSize > maxQueueSize) {
111-
logger.log(Level.WARNING, "maxExportBatchSize should not exceed maxQueueSize.");
112-
}
113110
this.maxQueueSize = maxQueueSize;
114111
return this;
115112
}
@@ -131,9 +128,6 @@ int getMaxQueueSize() {
131128
*/
132129
public BatchLogRecordProcessorBuilder setMaxExportBatchSize(int maxExportBatchSize) {
133130
checkArgument(maxExportBatchSize > 0, "maxExportBatchSize must be positive.");
134-
if (maxExportBatchSize > maxQueueSize) {
135-
logger.log(Level.WARNING, "maxExportBatchSize should not exceed maxQueueSize.");
136-
}
137131
this.maxExportBatchSize = maxExportBatchSize;
138132
return this;
139133
}
@@ -161,8 +155,11 @@ int getMaxExportBatchSize() {
161155
*/
162156
public BatchLogRecordProcessor build() {
163157
if (maxExportBatchSize > maxQueueSize) {
158+
logger.log(
159+
Level.WARNING,
160+
"maxExportBatchSize should not exceed maxQueueSize. Setting maxExportBatchSize to {0} instead of {1}",
161+
new Object[] {maxQueueSize, maxExportBatchSize});
164162
maxExportBatchSize = maxQueueSize;
165-
logger.log(Level.FINE, "Using maxExportBatchSize: {0}", maxExportBatchSize);
166163
}
167164
return new BatchLogRecordProcessor(
168165
logRecordExporter,

sdk/trace/src/main/java/io/opentelemetry/sdk/trace/export/BatchSpanProcessorBuilder.java

+4-7
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,6 @@ long getExporterTimeoutNanos() {
114114
*/
115115
public BatchSpanProcessorBuilder setMaxQueueSize(int maxQueueSize) {
116116
checkArgument(maxQueueSize > 0, "maxQueueSize must be positive.");
117-
if (maxExportBatchSize > maxQueueSize) {
118-
logger.log(Level.WARNING, "maxExportBatchSize should not exceed maxQueueSize.");
119-
}
120117
this.maxQueueSize = maxQueueSize;
121118
return this;
122119
}
@@ -138,9 +135,6 @@ int getMaxQueueSize() {
138135
*/
139136
public BatchSpanProcessorBuilder setMaxExportBatchSize(int maxExportBatchSize) {
140137
checkArgument(maxExportBatchSize > 0, "maxExportBatchSize must be positive.");
141-
if (maxExportBatchSize > maxQueueSize) {
142-
logger.log(Level.WARNING, "maxExportBatchSize should not exceed maxQueueSize.");
143-
}
144138
this.maxExportBatchSize = maxExportBatchSize;
145139
return this;
146140
}
@@ -168,8 +162,11 @@ int getMaxExportBatchSize() {
168162
*/
169163
public BatchSpanProcessor build() {
170164
if (maxExportBatchSize > maxQueueSize) {
165+
logger.log(
166+
Level.WARNING,
167+
"maxExportBatchSize should not exceed maxQueueSize. Setting maxExportBatchSize to {0} instead of {1}",
168+
new Object[] {maxQueueSize, maxExportBatchSize});
171169
maxExportBatchSize = maxQueueSize;
172-
logger.log(Level.FINE, "Using maxExportBatchSize: {0}", maxExportBatchSize);
173170
}
174171
return new BatchSpanProcessor(
175172
spanExporter,

0 commit comments

Comments
 (0)