Skip to content

Commit a5110ce

Browse files
committed
Add @export to package-info.java files for packages that should be importable from other modules. Various modules within this repo have packages with the namespace internal which are exposed via the apis of non internal classes and therefore had to be exposed
1 parent baf0eb4 commit a5110ce

File tree

93 files changed

+207
-0
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

93 files changed

+207
-0
lines changed

api/all/build.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ dependencies {
1515

1616
annotationProcessor("com.google.auto.value:auto-value")
1717

18+
compileOnly("org.osgi:osgi.annotation")
19+
1820
testImplementation("edu.berkeley.cs.jqf:jqf-fuzz")
1921
testImplementation("com.google.guava:guava-testlib")
2022
}

api/all/src/main/java/io/opentelemetry/api/baggage/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
*/
1616
// TODO: Add code examples.
1717
@ParametersAreNonnullByDefault
18+
@Export
1819
package io.opentelemetry.api.baggage;
1920

21+
import org.osgi.annotation.bundle.Export;
2022
import javax.annotation.ParametersAreNonnullByDefault;

api/all/src/main/java/io/opentelemetry/api/baggage/propagation/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
/** Default OpenTelemetry remote baggage propagators. */
77
@ParametersAreNonnullByDefault
8+
@Export
89
package io.opentelemetry.api.baggage.propagation;
910

11+
import org.osgi.annotation.bundle.Export;
1012
import javax.annotation.ParametersAreNonnullByDefault;

api/all/src/main/java/io/opentelemetry/api/common/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88
* io.opentelemetry.api.common.Attributes} and classes/utilities for interacting with them.
99
*/
1010
@ParametersAreNonnullByDefault
11+
@Export
1112
package io.opentelemetry.api.common;
1213

14+
import org.osgi.annotation.bundle.Export;
1315
import javax.annotation.ParametersAreNonnullByDefault;

api/all/src/main/java/io/opentelemetry/api/internal/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
* API, and must not be used by users of the OpenTelemetry library.
1111
*/
1212
@ParametersAreNonnullByDefault
13+
@Export
1314
package io.opentelemetry.api.internal;
1415

16+
import org.osgi.annotation.bundle.Export;
1517
import javax.annotation.ParametersAreNonnullByDefault;

api/all/src/main/java/io/opentelemetry/api/metrics/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
* scenarios where instrumentation authors are unable to obtain one by other means.
1616
*/
1717
@ParametersAreNonnullByDefault
18+
@Export
1819
package io.opentelemetry.api.metrics;
1920

21+
import org.osgi.annotation.bundle.Export;
2022
import javax.annotation.ParametersAreNonnullByDefault;

api/all/src/main/java/io/opentelemetry/api/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
* methods on {@link io.opentelemetry.api.OpenTelemetry}.
1111
*/
1212
@ParametersAreNonnullByDefault
13+
@Export
1314
package io.opentelemetry.api;
1415

16+
import org.osgi.annotation.bundle.Export;
1517
import javax.annotation.ParametersAreNonnullByDefault;

api/all/src/main/java/io/opentelemetry/api/trace/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
*/
2121
// TODO: Add code examples.
2222
@ParametersAreNonnullByDefault
23+
@Export
2324
package io.opentelemetry.api.trace;
2425

26+
import org.osgi.annotation.bundle.Export;
2527
import javax.annotation.ParametersAreNonnullByDefault;

api/all/src/main/java/io/opentelemetry/api/trace/propagation/internal/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
* API, and must not be used by users of the OpenTelemetry library.
1111
*/
1212
@ParametersAreNonnullByDefault
13+
@Export
1314
package io.opentelemetry.api.trace.propagation.internal;
1415

16+
import org.osgi.annotation.bundle.Export;
1517
import javax.annotation.ParametersAreNonnullByDefault;

api/all/src/main/java/io/opentelemetry/api/trace/propagation/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
/** Default OpenTelemetry remote trace propagators. */
77
@ParametersAreNonnullByDefault
8+
@Export
89
package io.opentelemetry.api.trace.propagation;
910

11+
import org.osgi.annotation.bundle.Export;
1012
import javax.annotation.ParametersAreNonnullByDefault;

context/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ description = "OpenTelemetry Context (Incubator)"
1010
otelJava.moduleName.set("io.opentelemetry.context")
1111

1212
dependencies {
13+
compileOnly("org.osgi:osgi.annotation")
1314
// MustBeClosed
1415
compileOnly("com.google.errorprone:error_prone_annotations")
1516

context/src/main/java/io/opentelemetry/context/internal/shaded/package-info.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,7 @@
44
* <p>All the content under this package and its subpackages are considered not part of the public
55
* API, and must not be used by users of the OpenTelemetry library.
66
*/
7+
@Export
78
package io.opentelemetry.context.internal.shaded;
9+
10+
import org.osgi.annotation.bundle.Export;

context/src/main/java/io/opentelemetry/context/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
* @see io.opentelemetry.context.Context
1111
*/
1212
@ParametersAreNonnullByDefault
13+
@Export
1314
package io.opentelemetry.context;
1415

16+
import org.osgi.annotation.bundle.Export;
1517
import javax.annotation.ParametersAreNonnullByDefault;

context/src/main/java/io/opentelemetry/context/propagation/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@
99
* remote server.
1010
*/
1111
@ParametersAreNonnullByDefault
12+
@Export
1213
package io.opentelemetry.context.propagation;
1314

15+
import org.osgi.annotation.bundle.Export;
1416
import javax.annotation.ParametersAreNonnullByDefault;

dependencyManagement/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ val DEPENDENCIES = listOf(
9999
"org.codehaus.mojo:animal-sniffer-annotations:1.21",
100100
"org.jctools:jctools-core:3.3.0",
101101
"org.junit-pioneer:junit-pioneer:1.7.1",
102+
"org.osgi:osgi.annotation:8.1.0",
102103
"org.skyscreamer:jsonassert:1.5.0",
103104
)
104105

exporters/jaeger-thrift/build.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ otelJava.moduleName.set("io.opentelemetry.exporter.jaeger.thrift")
1111
dependencies {
1212
api(project(":sdk:all"))
1313

14+
compileOnly("org.osgi:osgi.annotation")
15+
1416
implementation(project(":sdk:all"))
1517
implementation(project(":semconv"))
1618

exporters/jaeger-thrift/src/main/java/io/opentelemetry/exporter/jaeger/thrift/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
*/
55

66
@ParametersAreNonnullByDefault
7+
@Export
78
package io.opentelemetry.exporter.jaeger.thrift;
89

10+
import org.osgi.annotation.bundle.Export;
911
import javax.annotation.ParametersAreNonnullByDefault;

exporters/jaeger/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ dependencies {
2020
implementation(project(":exporters:otlp:common"))
2121
implementation(project(":semconv"))
2222

23+
compileOnly("org.osgi:osgi.annotation")
2324
compileOnly("io.grpc:grpc-stub")
2425

2526
implementation("com.fasterxml.jackson.jr:jackson-jr-objects")

exporters/jaeger/src/main/java/io/opentelemetry/exporter/jaeger/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
*/
55

66
@ParametersAreNonnullByDefault
7+
@Export
78
package io.opentelemetry.exporter.jaeger;
89

10+
import org.osgi.annotation.bundle.Export;
911
import javax.annotation.ParametersAreNonnullByDefault;

exporters/logging-otlp/build.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ description = "OpenTelemetry Protocol JSON Logging Exporters"
99
otelJava.moduleName.set("io.opentelemetry.exporter.logging.otlp")
1010

1111
dependencies {
12+
compileOnly("org.osgi:osgi.annotation")
13+
1214
compileOnly(project(":sdk:trace"))
1315
compileOnly(project(":sdk:metrics"))
1416
compileOnly(project(":sdk:logs"))

exporters/logging-otlp/src/main/java/io/opentelemetry/exporter/logging/otlp/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
/** OpenTelemetry exporters which writes spans or metrics to log using OTLP JSON format. */
77
@ParametersAreNonnullByDefault
8+
@Export
89
package io.opentelemetry.exporter.logging.otlp;
910

11+
import org.osgi.annotation.bundle.Export;
1012
import javax.annotation.ParametersAreNonnullByDefault;

exporters/logging/build.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,7 @@ dependencies {
1313
api(project(":sdk:metrics"))
1414
api(project(":sdk:logs"))
1515

16+
compileOnly("org.osgi:osgi.annotation")
17+
1618
testImplementation(project(":sdk:testing"))
1719
}

exporters/logging/src/main/java/io/opentelemetry/exporter/logging/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
*/
55

66
@ParametersAreNonnullByDefault
7+
@Export
78
package io.opentelemetry.exporter.logging;
89

10+
import org.osgi.annotation.bundle.Export;
911
import javax.annotation.ParametersAreNonnullByDefault;

exporters/otlp/all/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ dependencies {
1616

1717
implementation(project(":exporters:otlp:common"))
1818

19+
compileOnly("org.osgi:osgi.annotation")
1920
compileOnly("io.grpc:grpc-stub")
2021

2122
testImplementation(project(":exporters:otlp:testing-internal"))

exporters/otlp/all/src/main/java/io/opentelemetry/exporter/otlp/http/metrics/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
/** OpenTelemetry exporter which sends metric data to OpenTelemetry collector via OTLP HTTP. */
77
@ParametersAreNonnullByDefault
8+
@Export
89
package io.opentelemetry.exporter.otlp.http.metrics;
910

11+
import org.osgi.annotation.bundle.Export;
1012
import javax.annotation.ParametersAreNonnullByDefault;

exporters/otlp/all/src/main/java/io/opentelemetry/exporter/otlp/http/trace/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
/** OpenTelemetry exporter which sends span data to OpenTelemetry collector via OTLP HTTP. */
77
@ParametersAreNonnullByDefault
8+
@Export
89
package io.opentelemetry.exporter.otlp.http.trace;
910

11+
import org.osgi.annotation.bundle.Export;
1012
import javax.annotation.ParametersAreNonnullByDefault;

exporters/otlp/all/src/main/java/io/opentelemetry/exporter/otlp/metrics/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
/** OpenTelemetry exporter which sends metric data to OpenTelemetry collector via OTLP gRPC. */
77
@ParametersAreNonnullByDefault
8+
@Export
89
package io.opentelemetry.exporter.otlp.metrics;
910

11+
import org.osgi.annotation.bundle.Export;
1012
import javax.annotation.ParametersAreNonnullByDefault;

exporters/otlp/all/src/main/java/io/opentelemetry/exporter/otlp/trace/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
/** OpenTelemetry exporter which sends span data to OpenTelemetry collector via OTLP gRPC. */
77
@ParametersAreNonnullByDefault
8+
@Export
89
package io.opentelemetry.exporter.otlp.trace;
910

11+
import org.osgi.annotation.bundle.Export;
1012
import javax.annotation.ParametersAreNonnullByDefault;

exporters/otlp/common/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ dependencies {
1717

1818
api(project(":api:all"))
1919

20+
compileOnly("org.osgi:osgi.annotation")
2021
compileOnly(project(":sdk:metrics"))
2122
compileOnly(project(":sdk:trace"))
2223
compileOnly(project(":sdk:logs"))

exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/grpc/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
/** Utilities for gRPC exporters. */
77
@ParametersAreNonnullByDefault
8+
@Export
89
package io.opentelemetry.exporter.internal.grpc;
910

11+
import org.osgi.annotation.bundle.Export;
1012
import javax.annotation.ParametersAreNonnullByDefault;

exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/marshal/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
/** Marshaling framework for serializing data to protobuf format. */
77
@ParametersAreNonnullByDefault
8+
@Export
89
package io.opentelemetry.exporter.internal.marshal;
910

11+
import org.osgi.annotation.bundle.Export;
1012
import javax.annotation.ParametersAreNonnullByDefault;

exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/okhttp/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
/** Utilities for HTTP exporters. */
77
@ParametersAreNonnullByDefault
8+
@Export
89
package io.opentelemetry.exporter.internal.okhttp;
910

11+
import org.osgi.annotation.bundle.Export;
1012
import javax.annotation.ParametersAreNonnullByDefault;

exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/otlp/logs/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
/** Marshaling of OTLP logs. */
77
@ParametersAreNonnullByDefault
8+
@Export
89
package io.opentelemetry.exporter.internal.otlp.logs;
910

11+
import org.osgi.annotation.bundle.Export;
1012
import javax.annotation.ParametersAreNonnullByDefault;

exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/otlp/metrics/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
/** Marshaling of OTLP metrics. */
77
@ParametersAreNonnullByDefault
8+
@Export
89
package io.opentelemetry.exporter.internal.otlp.metrics;
910

11+
import org.osgi.annotation.bundle.Export;
1012
import javax.annotation.ParametersAreNonnullByDefault;

exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/otlp/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
* at any time.
1111
*/
1212
@ParametersAreNonnullByDefault
13+
@Export
1314
package io.opentelemetry.exporter.internal.otlp;
1415

16+
import org.osgi.annotation.bundle.Export;
1517
import javax.annotation.ParametersAreNonnullByDefault;

exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/otlp/traces/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
/** Marshaling of OTLP traces. */
77
@ParametersAreNonnullByDefault
8+
@Export
89
package io.opentelemetry.exporter.internal.otlp.traces;
910

11+
import org.osgi.annotation.bundle.Export;
1012
import javax.annotation.ParametersAreNonnullByDefault;

exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
/** Internal utilities for exporters. */
77
@ParametersAreNonnullByDefault
8+
@Export
89
package io.opentelemetry.exporter.internal;
910

11+
import org.osgi.annotation.bundle.Export;
1012
import javax.annotation.ParametersAreNonnullByDefault;

exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/retry/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
/** Logic for retrying of export requests. */
77
@ParametersAreNonnullByDefault
8+
@Export
89
package io.opentelemetry.exporter.internal.retry;
910

11+
import org.osgi.annotation.bundle.Export;
1012
import javax.annotation.ParametersAreNonnullByDefault;

exporters/otlp/logs/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ dependencies {
1313

1414
implementation(project(":exporters:otlp:common"))
1515

16+
compileOnly("org.osgi:osgi.annotation")
1617
compileOnly("io.grpc:grpc-stub")
1718

1819
testImplementation(project(":exporters:otlp:testing-internal"))

exporters/otlp/logs/src/main/java/io/opentelemetry/exporter/otlp/http/logs/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
/** OpenTelemetry exporter which sends log data to OpenTelemetry collector via OTLP HTTP. */
77
@ParametersAreNonnullByDefault
8+
@Export
89
package io.opentelemetry.exporter.otlp.http.logs;
910

11+
import org.osgi.annotation.bundle.Export;
1012
import javax.annotation.ParametersAreNonnullByDefault;

exporters/otlp/logs/src/main/java/io/opentelemetry/exporter/otlp/logs/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
/** OpenTelemetry exporter which sends span data to OpenTelemetry collector via OTLP gRPC. */
77
@ParametersAreNonnullByDefault
8+
@Export
89
package io.opentelemetry.exporter.otlp.logs;
910

11+
import org.osgi.annotation.bundle.Export;
1012
import javax.annotation.ParametersAreNonnullByDefault;

exporters/prometheus/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ dependencies {
1212
api(project(":sdk:metrics"))
1313

1414
compileOnly("com.sun.net.httpserver:http")
15+
compileOnly("org.osgi:osgi.annotation")
1516

1617
testImplementation("com.google.guava:guava")
1718
testImplementation("com.linecorp.armeria:armeria")

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
*/
55

66
@ParametersAreNonnullByDefault
7+
@Export
78
package io.opentelemetry.exporter.prometheus;
89

10+
import org.osgi.annotation.bundle.Export;
911
import javax.annotation.ParametersAreNonnullByDefault;

exporters/zipkin/build.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ dependencies {
1313

1414
api("io.zipkin.reporter2:zipkin-reporter")
1515

16+
compileOnly("org.osgi:osgi.annotation")
17+
1618
implementation(project(":semconv"))
1719

1820
implementation("io.zipkin.reporter2:zipkin-sender-okhttp3")

exporters/zipkin/src/main/java/io/opentelemetry/exporter/zipkin/package-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
*/
55

66
@ParametersAreNonnullByDefault
7+
@Export
78
package io.opentelemetry.exporter.zipkin;
89

10+
import org.osgi.annotation.bundle.Export;
911
import javax.annotation.ParametersAreNonnullByDefault;

0 commit comments

Comments
 (0)