Skip to content

Commit 038f9e5

Browse files
authored
Merge branch 'main' into main
2 parents a294d7f + 4de0e56 commit 038f9e5

File tree

11 files changed

+10
-128
lines changed

11 files changed

+10
-128
lines changed

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1616
([#2300](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2300))
1717
- Rename AwsLambdaInstrumentor span attributes `faas.id` to `cloud.resource_id`, `faas.execution` to `faas.invocation_id`
1818
([#2372](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2372))
19+
- Drop support for instrumenting elasticsearch client < 6`
20+
([#2422](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2422))
1921

2022
### Added
2123

docs-requirements.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ boto3~=1.0
2828
cassandra-driver~=3.25
2929
celery>=4.0
3030
confluent-kafka>= 1.8.2,<= 2.3.0
31-
elasticsearch>=2.0,<9.0
31+
elasticsearch>=6.0,<9.0
3232
flask~=2.0
3333
falcon~=2.0
3434
grpcio~=1.27

instrumentation/opentelemetry-instrumentation-elasticsearch/pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ dependencies = [
3232

3333
[project.optional-dependencies]
3434
instruments = [
35-
"elasticsearch >= 2.0",
35+
"elasticsearch >= 6.0",
3636
]
3737

3838
[project.entry-points.opentelemetry_instrumentor]

instrumentation/opentelemetry-instrumentation-elasticsearch/test-requirements-0.txt

-22
This file was deleted.

instrumentation/opentelemetry-instrumentation-elasticsearch/test-requirements-1.txt

-22
This file was deleted.

instrumentation/opentelemetry-instrumentation-elasticsearch/tests/helpers_es2.py

-33
This file was deleted.

instrumentation/opentelemetry-instrumentation-elasticsearch/tests/helpers_es5.py

-33
This file was deleted.

instrumentation/opentelemetry-instrumentation-elasticsearch/tests/test_elasticsearch.py

-4
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,6 @@
4444
from . import helpers_es7 as helpers # pylint: disable=no-name-in-module
4545
elif major_version == 6:
4646
from . import helpers_es6 as helpers # pylint: disable=no-name-in-module
47-
elif major_version == 5:
48-
from . import helpers_es5 as helpers # pylint: disable=no-name-in-module
49-
else:
50-
from . import helpers_es2 as helpers # pylint: disable=no-name-in-module
5147

5248
Article = helpers.Article
5349

opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap_gen.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@
7373
"instrumentation": "opentelemetry-instrumentation-django==0.46b0.dev",
7474
},
7575
{
76-
"library": "elasticsearch >= 2.0",
76+
"library": "elasticsearch >= 6.0",
7777
"instrumentation": "opentelemetry-instrumentation-elasticsearch==0.46b0.dev",
7878
},
7979
{

tox.ini

+5-11
Original file line numberDiff line numberDiff line change
@@ -78,13 +78,9 @@ envlist =
7878
; FIXME: Elasticsearch >=7 causes CI workflow tests to hang, see open-telemetry/opentelemetry-python-contrib#620
7979
; The numbers at the end of the environment names
8080
; below mean these dependencies are being used:
81-
; 0: elasticsearch-dsl>=2.0,<3.0 elasticsearch>=2.0,<3.0
82-
; 1: elasticsearch-dsl>=5.0,<6.0 elasticsearch>=5.0,<6.0
83-
; 2: elasticsearch-dsl>=6.0,<7.0 elasticsearch>=6.0,<7.0
84-
py3{8,9,10,11}-test-instrumentation-elasticsearch-{0,2}
85-
pypy3-test-instrumentation-elasticsearch-{0,2}
86-
py3{8,9}-test-instrumentation-elasticsearch-1
87-
pypy3-test-instrumentation-elasticsearch-1
81+
; 6: elasticsearch-dsl>=6.0,<7.0 elasticsearch>=6.0,<7.0
82+
py3{8,9,10,11}-test-instrumentation-elasticsearch-6
83+
pypy3-test-instrumentation-elasticsearch-6
8884

8985
; opentelemetry-instrumentation-falcon
9086
; py310 does not work with falcon 1
@@ -452,9 +448,7 @@ commands_pre =
452448
sqlalchemy-0: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-sqlalchemy/test-requirements-0.txt
453449
sqlalchemy-1: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-sqlalchemy/test-requirements-1.txt
454450

455-
elasticsearch-0: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-elasticsearch/test-requirements-0.txt
456-
elasticsearch-1: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-elasticsearch/test-requirements-1.txt
457-
elasticsearch-2: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-elasticsearch/test-requirements-2.txt
451+
elasticsearch-6: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-elasticsearch/test-requirements-6.txt
458452

459453
asyncio: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-asyncio/test-requirements.txt
460454

@@ -617,7 +611,7 @@ commands_pre =
617611
# prerequisite: follow the instructions here https://github.com/PyMySQL/mysqlclient#install
618612
# for your OS to install the required dependencies
619613
pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-mysqlclient/test-requirements.txt
620-
pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-elasticsearch/test-requirements-2.txt
614+
pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-elasticsearch/test-requirements-6.txt
621615
pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-tornado/test-requirements.txt
622616
pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-asyncpg/test-requirements.txt
623617
pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-pymongo/test-requirements.txt

0 commit comments

Comments
 (0)