Skip to content

Commit 0dc372e

Browse files
committed
Remove usage of _time_ns
1 parent 858e7b8 commit 0dc372e

File tree

7 files changed

+15
-15
lines changed
  • .github/workflows
  • exporter/opentelemetry-exporter-datadog/src/opentelemetry/exporter/datadog
  • instrumentation
    • opentelemetry-instrumentation-falcon/src/opentelemetry/instrumentation/falcon
    • opentelemetry-instrumentation-flask/src/opentelemetry/instrumentation/flask
    • opentelemetry-instrumentation-pyramid/src/opentelemetry/instrumentation/pyramid
    • opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado

7 files changed

+15
-15
lines changed

Diff for: .github/workflows/test.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ on:
66
- 'release/*'
77
pull_request:
88
env:
9-
CORE_REPO_SHA: 75846aa0e0a5960661b1d8d7441d2df921e6a97b
9+
CORE_REPO_SHA: a6324d891365f61e3631dabd68f3321482f15c51
1010

1111
jobs:
1212
build:

Diff for: exporter/opentelemetry-exporter-datadog/src/opentelemetry/exporter/datadog/spanprocessor.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@
1616
import logging
1717
import threading
1818
import typing
19+
from time import time_ns
1920

2021
from opentelemetry.context import Context, attach, detach, set_value
2122
from opentelemetry.instrumentation.utils import _SUPPRESS_INSTRUMENTATION_KEY
2223
from opentelemetry.sdk.trace import Span, SpanProcessor
2324
from opentelemetry.sdk.trace.export import SpanExporter
2425
from opentelemetry.trace import INVALID_TRACE_ID
25-
from opentelemetry.util._time import _time_ns
2626

2727
logger = logging.getLogger(__name__)
2828

@@ -128,9 +128,9 @@ def worker(self):
128128
break
129129

130130
# substract the duration of this export call to the next timeout
131-
start = _time_ns()
131+
start = time_ns()
132132
self.export()
133-
end = _time_ns()
133+
end = time_ns()
134134
duration = (end - start) / 1e9
135135
timeout = self.schedule_delay_millis / 1e3 - duration
136136

Diff for: instrumentation/opentelemetry-instrumentation-falcon/src/opentelemetry/instrumentation/falcon/__init__.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ def response_hook(span, req, resp):
141141
---
142142
"""
143143

144+
from time import time_ns
144145
from logging import getLogger
145146
from sys import exc_info
146147
from typing import Collection
@@ -164,7 +165,6 @@ def response_hook(span, req, resp):
164165
)
165166
from opentelemetry.semconv.trace import SpanAttributes
166167
from opentelemetry.trace.status import Status
167-
from opentelemetry.util._time import _time_ns
168168
from opentelemetry.util.http import get_excluded_urls, get_traced_request_attrs
169169

170170
_logger = getLogger(__name__)
@@ -253,7 +253,7 @@ def __call__(self, env, start_response):
253253
if self._otel_excluded_urls.url_disabled(env.get("PATH_INFO", "/")):
254254
return super().__call__(env, start_response)
255255

256-
start_time = _time_ns()
256+
start_time = time_ns()
257257

258258
span, token = _start_internal_or_server_span(
259259
tracer=self._otel_tracer,

Diff for: instrumentation/opentelemetry-instrumentation-flask/src/opentelemetry/instrumentation/flask/__init__.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,7 @@ def response_hook(span: Span, status: str, response_headers: List):
143143
from logging import getLogger
144144
from timeit import default_timer
145145
from typing import Collection
146+
from time import time_ns
146147

147148
import flask
148149

@@ -157,7 +158,6 @@ def response_hook(span: Span, status: str, response_headers: List):
157158
from opentelemetry.instrumentation.utils import _start_internal_or_server_span
158159
from opentelemetry.metrics import get_meter
159160
from opentelemetry.semconv.trace import SpanAttributes
160-
from opentelemetry.util._time import _time_ns
161161
from opentelemetry.util.http import get_excluded_urls, parse_excluded_urls
162162

163163
_logger = getLogger(__name__)
@@ -191,7 +191,7 @@ def _wrapped_app(wrapped_app_environ, start_response):
191191
# In theory, we could start the span here and use
192192
# update_name later but that API is "highly discouraged" so
193193
# we better avoid it.
194-
wrapped_app_environ[_ENVIRON_STARTTIME_KEY] = _time_ns()
194+
wrapped_app_environ[_ENVIRON_STARTTIME_KEY] = time_ns()
195195
start = default_timer()
196196
attributes = otel_wsgi.collect_request_attributes(wrapped_app_environ)
197197
active_requests_count_attrs = (

Diff for: instrumentation/opentelemetry-instrumentation-pyramid/src/opentelemetry/instrumentation/pyramid/callbacks.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
# limitations under the License.
1414

1515
from logging import getLogger
16+
from time import time_ns
1617

1718
from pyramid.events import BeforeTraversal
1819
from pyramid.httpexceptions import HTTPException, HTTPServerError
@@ -27,7 +28,6 @@
2728
from opentelemetry.instrumentation.pyramid.version import __version__
2829
from opentelemetry.instrumentation.utils import _start_internal_or_server_span
2930
from opentelemetry.semconv.trace import SpanAttributes
30-
from opentelemetry.util._time import _time_ns
3131
from opentelemetry.util.http import get_excluded_urls
3232

3333
TWEEN_NAME = "opentelemetry.instrumentation.pyramid.trace_tween_factory"
@@ -144,7 +144,7 @@ def trace_tween(request):
144144
return handler(request)
145145

146146
request.environ[_ENVIRON_ENABLED_KEY] = True
147-
request.environ[_ENVIRON_STARTTIME_KEY] = _time_ns()
147+
request.environ[_ENVIRON_STARTTIME_KEY] = time_ns()
148148

149149
response = None
150150
status = None

Diff for: instrumentation/opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/__init__.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,7 @@ def client_resposne_hook(span, future):
157157
from functools import partial
158158
from logging import getLogger
159159
from typing import Collection
160+
from time import time_ns
160161

161162
import tornado.web
162163
import wrapt
@@ -179,7 +180,6 @@ def client_resposne_hook(span, future):
179180
from opentelemetry.propagators import textmap
180181
from opentelemetry.semconv.trace import SpanAttributes
181182
from opentelemetry.trace.status import Status, StatusCode
182-
from opentelemetry.util._time import _time_ns
183183
from opentelemetry.util.http import (
184184
OTEL_INSTRUMENTATION_HTTP_CAPTURE_HEADERS_SERVER_REQUEST,
185185
OTEL_INSTRUMENTATION_HTTP_CAPTURE_HEADERS_SERVER_RESPONSE,
@@ -290,7 +290,7 @@ def _wrap(cls, method_name, wrapper):
290290

291291

292292
def _prepare(tracer, request_hook, func, handler, args, kwargs):
293-
start_time = _time_ns()
293+
start_time = time_ns()
294294
request = handler.request
295295
if _excluded_urls.url_disabled(request.uri):
296296
return func(*args, **kwargs)
@@ -423,7 +423,7 @@ def _finish_span(tracer, handler, error=None):
423423
if isinstance(error, tornado.web.HTTPError):
424424
status_code = error.status_code
425425
if not ctx and status_code == 404:
426-
ctx = _start_span(tracer, handler, _time_ns())
426+
ctx = _start_span(tracer, handler, time_ns())
427427
else:
428428
status_code = 500
429429
reason = None

Diff for: instrumentation/opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/client.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
# limitations under the License.
1414

1515
import functools
16+
from time import time_ns
1617

1718
from tornado.httpclient import HTTPError, HTTPRequest
1819

@@ -21,7 +22,6 @@
2122
from opentelemetry.propagate import inject
2223
from opentelemetry.semconv.trace import SpanAttributes
2324
from opentelemetry.trace.status import Status
24-
from opentelemetry.util._time import _time_ns
2525
from opentelemetry.util.http import remove_url_credentials
2626

2727

@@ -42,7 +42,7 @@ def _normalize_request(args, kwargs):
4242

4343

4444
def fetch_async(tracer, request_hook, response_hook, func, _, args, kwargs):
45-
start_time = _time_ns()
45+
start_time = time_ns()
4646

4747
# Return immediately if no args were provided (error)
4848
# or original_request is set (meaning we are in a redirect step).

0 commit comments

Comments
 (0)