Skip to content

Commit 11cdcc3

Browse files
committed
Clean up
1 parent 6ad9850 commit 11cdcc3

File tree

1 file changed

+4
-20
lines changed

1 file changed

+4
-20
lines changed

Diff for: instrumentation/opentelemetry-instrumentation-fastapi/tests/test_fastapi_instrumentation.py

+4-20
Original file line numberDiff line numberDiff line change
@@ -16,26 +16,20 @@
1616

1717
from pkg_resources import (
1818
DistributionNotFound,
19-
EntryPoint,
20-
get_distribution,
21-
iter_entry_points
19+
iter_entry_points,
2220
)
2321
import unittest
2422
from timeit import default_timer
2523
from unittest.mock import (
2624
Mock,
27-
patch
25+
patch,
2826
)
2927
import fastapi
3028
from fastapi.middleware.httpsredirect import HTTPSRedirectMiddleware
3129
from fastapi.responses import JSONResponse
3230
from fastapi.testclient import TestClient
3331

3432
import opentelemetry.instrumentation.fastapi as otel_fastapi
35-
from opentelemetry.instrumentation.dependencies import (
36-
get_dist_dependency_conflicts,
37-
get_dependency_conflicts
38-
)
3933
from opentelemetry import trace
4034
from opentelemetry.instrumentation.auto_instrumentation._load import _load_instrumentors
4135
from opentelemetry.instrumentation._semconv import (
@@ -1054,8 +1048,6 @@ class TestAutoInstrumentation(TestBaseAutoFastAPI):
10541048
to both.
10551049
"""
10561050

1057-
entry_point = EntryPoint.parse('fastapi = opentelemetry.instrumentation.fastapi:FastAPIInstrumentor')
1058-
10591051
def test_entry_point_exists(self):
10601052
eps = iter_entry_points("opentelemetry_instrumentor")
10611053
ep = next(eps)
@@ -1065,12 +1057,8 @@ def test_entry_point_exists(self):
10651057
self.assertEqual(ep.name, 'fastapi')
10661058
self.assertIsNone(next(eps, None))
10671059

1068-
@patch("opentelemetry.instrumentation.auto_instrumentation._load.get_dist_dependency_conflicts")
1069-
@patch("opentelemetry.instrumentation.dependencies.get_dependency_conflicts")
10701060
@patch("opentelemetry.instrumentation.dependencies.get_distribution")
1071-
def test_instruments_with_fastapi_installed(self, mock_get_distribution, mock_get_dependency_conflicts, mock_get_dist_dependency_conflicts):
1072-
mock_get_dist_dependency_conflicts.side_effect = get_dist_dependency_conflicts
1073-
mock_get_dependency_conflicts.side_effect = get_dependency_conflicts
1061+
def test_instruments_with_fastapi_installed(self, mock_get_distribution):
10741062
mock_get_distribution.side_effect = get_distribution_with_fastapi
10751063
mock_distro = Mock()
10761064
_load_instrumentors(mock_distro)
@@ -1083,12 +1071,8 @@ def test_instruments_with_fastapi_installed(self, mock_get_distribution, mock_ge
10831071
self.assertEqual(ep.attrs, ('FastAPIInstrumentor',))
10841072
self.assertEqual(ep.name, 'fastapi')
10851073

1086-
@patch("opentelemetry.instrumentation.auto_instrumentation._load.get_dist_dependency_conflicts")
1087-
@patch("opentelemetry.instrumentation.dependencies.get_dependency_conflicts")
10881074
@patch("opentelemetry.instrumentation.dependencies.get_distribution")
1089-
def test_instruments_without_fastapi_installed(self, mock_get_distribution, mock_get_dependency_conflicts, mock_get_dist_dependency_conflicts):
1090-
mock_get_dist_dependency_conflicts.side_effect = get_dist_dependency_conflicts
1091-
mock_get_dependency_conflicts.side_effect = get_dependency_conflicts
1075+
def test_instruments_without_fastapi_installed(self, mock_get_distribution):
10921076
mock_get_distribution.side_effect = get_distribution_without_fastapi
10931077
mock_distro = Mock()
10941078
_load_instrumentors(mock_distro)

0 commit comments

Comments
 (0)