Skip to content

Commit 14b0bc5

Browse files
fix format of changelog and test cases
Signed-off-by: Shi, Stone <[email protected]>
1 parent 88ef2c7 commit 14b0bc5

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

Diff for: CHANGELOG.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2626
([#2750](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2750))
2727
- `opentelemetry-instrumentation-django` Fix regression - `http.target` re-added back to old semconv duration metrics
2828
([#2746](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2746))
29-
- `opentelemetry-instrumentation-asgi` do not set url.full attribute for server spans
29+
- `opentelemetry-instrumentation-asgi` do not set `url.full` attribute for server spans
3030
([#2735](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2735))
3131
- `opentelemetry-instrumentation-grpc` Fixes the issue with the gRPC instrumentation not working with the 1.63.0 and higher version of gRPC
3232
([#2483](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2484))

Diff for: instrumentation/opentelemetry-instrumentation-asgi/tests/test_asgi_middleware.py

+15
Original file line numberDiff line numberDiff line change
@@ -1683,6 +1683,17 @@ def test_query_string(self):
16831683
attrs[SpanAttributes.HTTP_URL], "http://127.0.0.1/?foo=bar"
16841684
)
16851685

1686+
def test_query_string_new_semconv(self):
1687+
self.scope["query_string"] = b"foo=bar"
1688+
attrs = otel_asgi.collect_request_attributes(
1689+
self.scope,
1690+
_HTTPStabilityMode.HTTP,
1691+
)
1692+
self.assertEqual(attrs[URL_SCHEME], "http")
1693+
self.assertEqual(attrs[SERVER_ADDRESS], "127.0.0.1")
1694+
self.assertEqual(attrs[URL_PATH], "/")
1695+
self.assertEqual(attrs[URL_QUERY], "foo=bar")
1696+
16861697
def test_query_string_both_semconv(self):
16871698
self.scope["query_string"] = b"foo=bar"
16881699
attrs = otel_asgi.collect_request_attributes(
@@ -1692,6 +1703,10 @@ def test_query_string_both_semconv(self):
16921703
self.assertEqual(
16931704
attrs[SpanAttributes.HTTP_URL], "http://127.0.0.1/?foo=bar"
16941705
)
1706+
self.assertEqual(attrs[URL_SCHEME], "http")
1707+
self.assertEqual(attrs[SERVER_ADDRESS], "127.0.0.1")
1708+
self.assertEqual(attrs[URL_PATH], "/")
1709+
self.assertEqual(attrs[URL_QUERY], "foo=bar")
16951710

16961711
def test_query_string_percent_bytes(self):
16971712
self.scope["query_string"] = b"foo%3Dbar"

0 commit comments

Comments
 (0)