Skip to content

Commit 15e09d3

Browse files
committed
Skip creating span for redisearch methods in _traced_execute_command
1 parent 191ef9d commit 15e09d3

File tree

2 files changed

+13
-2
lines changed
  • instrumentation/opentelemetry-instrumentation-redis/src/opentelemetry/instrumentation/redis

2 files changed

+13
-2
lines changed

Diff for: instrumentation/opentelemetry-instrumentation-redis/src/opentelemetry/instrumentation/redis/__init__.py

+5-2
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ def response_hook(span, instance, response):
102102
from opentelemetry.instrumentation.redis.package import _instruments
103103
from opentelemetry.instrumentation.redis.util import (
104104
_args_or_none,
105+
_check_skip,
105106
_extract_conn_attributes,
106107
_format_command_args,
107108
_set_span_attribute,
@@ -184,7 +185,8 @@ def _instrument(
184185
def _traced_execute_command(func, instance, args, kwargs):
185186
query = _format_command_args(args)
186187
name = _build_span_name(instance, args)
187-
188+
if _check_skip(name):
189+
return func(*args, **kwargs)
188190
with tracer.start_as_current_span(
189191
name, kind=trace.SpanKind.CLIENT
190192
) as span:
@@ -205,7 +207,8 @@ def _traced_execute_pipeline(func, instance, args, kwargs):
205207
resource,
206208
span_name,
207209
) = _build_span_meta_data_for_pipeline(instance)
208-
210+
if _check_skip(span_name):
211+
return func(*args, **kwargs)
209212
with tracer.start_as_current_span(
210213
span_name, kind=trace.SpanKind.CLIENT
211214
) as span:

Diff for: instrumentation/opentelemetry-instrumentation-redis/src/opentelemetry/instrumentation/redis/util.py

+8
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,14 @@ def _format_command_args(args):
7070
return out_str
7171

7272

73+
def _check_skip(name):
74+
skip_list = ["FT.SEARCH", "FT.CREATE", "FT.AGGREGATE"]
75+
for method in skip_list:
76+
if method in name:
77+
return True
78+
return False
79+
80+
7381
def _set_span_attribute(span, name, value):
7482
if value is not None:
7583
if value != "":

0 commit comments

Comments
 (0)