Skip to content

Commit 197165e

Browse files
committed
Implement missing context methods
Fixes #321
1 parent 7980997 commit 197165e

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
66

77
## [Unreleased](https://github.com/open-telemetry/opentelemetry-python-contrib/compare/v0.18b0...HEAD)
88

9+
- Implement context methods for `_InterceptorChannel`
10+
([#363](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/363))
11+
912
### Changed
1013
- Rename `IdsGenerator` to `IdGenerator`
1114
([#350](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/350))

instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/_server.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
from opentelemetry import trace
3030
from opentelemetry.context import attach, detach
3131
from opentelemetry.propagate import extract
32-
from opentelemetry.trace.propagation.textmap import DictGetter
32+
from opentelemetry.propagators.textmap import DictGetter
3333
from opentelemetry.trace.status import Status, StatusCode
3434

3535
logger = logging.getLogger(__name__)

instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/grpcext/_interceptor.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -232,11 +232,11 @@ def close(self):
232232

233233
def __enter__(self):
234234
"""Enters the runtime context related to the channel object."""
235-
raise NotImplementedError()
235+
return self
236236

237237
def __exit__(self, exc_type, exc_val, exc_tb):
238238
"""Exits the runtime context related to the channel object."""
239-
raise NotImplementedError()
239+
self.close()
240240

241241

242242
def intercept_channel(channel, *interceptors):

0 commit comments

Comments
 (0)