Skip to content

Commit 20083fb

Browse files
authored
Merge branch 'main' into feature/asyncio-instrumentation
2 parents 4687b20 + a93bd74 commit 20083fb

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
99

1010
- `opentelemetry-resource-detector-azure` Added 10s timeout to VM Resource Detector
1111
([#2119](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2119))
12+
- `opentelemetry-resource-detector-azure` Changed timeout to 4 seconds due to [timeout bug](https://github.com/open-telemetry/opentelemetry-python/issues/3644)
13+
([#2136](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2136))
1214

1315
## Version 1.22.0/0.43b0 (2023-12-14)
1416

resource/opentelemetry-resource-detector-azure/src/opentelemetry/resource/detector/azure/version.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
__version__ = "0.1.1"
15+
__version__ = "0.1.2"

resource/opentelemetry-resource-detector-azure/src/opentelemetry/resource/detector/azure/vm.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,10 @@ def get_azure_vm_metadata(self): # pylint: disable=no-self-use
6868
request = Request(_AZURE_VM_METADATA_ENDPOINT)
6969
request.add_header("Metadata", "True")
7070
try:
71-
with urlopen(request, timeout=10) as response:
71+
# TODO: Changed to 4s to fit into OTel SDK's 5 second timeout.
72+
# Lengthen or allow user input if issue is resolved.
73+
# See https://github.com/open-telemetry/opentelemetry-python/issues/3644
74+
with urlopen(request, timeout=4) as response:
7275
return loads(response.read())
7376
except URLError:
7477
# Not on Azure VM

0 commit comments

Comments
 (0)