Skip to content

Commit 213682e

Browse files
author
Michael Stella
committed
Format span error description properly
1 parent 30b68bf commit 213682e

File tree

1 file changed

+12
-3
lines changed
  • instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc

1 file changed

+12
-3
lines changed

instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/_server.py

+12-3
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,10 @@ def abort(self, code, details):
115115
self.details = details
116116
self._active_span.set_attribute("rpc.grpc.status_code", code.value[0])
117117
self._active_span.set_status(
118-
Status(status_code=StatusCode.ERROR, description=details)
118+
Status(
119+
status_code=StatusCode.ERROR,
120+
description="{}:{}".format(code, details),
121+
)
119122
)
120123
return self._servicer_context.abort(code, details)
121124

@@ -129,15 +132,21 @@ def set_code(self, code):
129132
self._active_span.set_attribute("rpc.grpc.status_code", code.value[0])
130133
if code != grpc.StatusCode.OK:
131134
self._active_span.set_status(
132-
Status(status_code=StatusCode.ERROR, description=details)
135+
Status(
136+
status_code=StatusCode.ERROR,
137+
description="{}:{}".format(code, details),
138+
)
133139
)
134140
return self._servicer_context.set_code(code)
135141

136142
def set_details(self, details):
137143
self.details = details
138144
if self.code != grpc.StatusCode.OK:
139145
self._active_span.set_status(
140-
Status(status_code=StatusCode.ERROR, description=details)
146+
Status(
147+
status_code=StatusCode.ERROR,
148+
description="{}:{}".format(self.code, details),
149+
)
141150
)
142151
return self._servicer_context.set_details(details)
143152

0 commit comments

Comments
 (0)