record exception when exc is not a HTTPError

jgibo · jgibo · commit 252febabeb5f · 2024-08-13T11:43:20.000+08:00
diff --git a/instrumentation/opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/client.py b/instrumentation/opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/client.py
@@ -125,6 +125,7 @@ def _finish_tracing_callback(
                 status_code=StatusCode.ERROR,
                 description=description,
             )
+            span.record_exception(exc)
     else:
         response = future.result()
         status_code = response.code

Original file line number	Diff line number	Diff line change
`@@ -125,6 +125,7 @@ def _finish_tracing_callback(`
`125`	`125`	`status_code=StatusCode.ERROR,`
`126`	`126`	`description=description,`
`127`	`127`	`)`
	`128`	`+ span.record_exception(exc)`
`128`	`129`	`else:`
`129`	`130`	`response = future.result()`
`130`	`131`	`status_code = response.code`