Skip to content

Commit 2bcb6ae

Browse files
mattoberleowais
andauthored
Fix missing 'packaging' requirement (#713)
The `sqlalchemy` instrumentation uses the `packaging` library to parse the `sqlalchemy` SemVer. `packaging` is not part of the standard library and should be included in the `setup.cfg` file to avoid: ``` ModuleNotFoundError: No module named 'packaging' ``` Co-authored-by: Matt Oberle <[email protected]> Co-authored-by: Owais Lone <[email protected]>
1 parent fb24599 commit 2bcb6ae

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

Diff for: CHANGELOG.md

+5
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

88
## [Unreleased](https://github.com/open-telemetry/opentelemetry-python/compare/v1.5.0-0.24b0...HEAD)
9+
- `opentelemetry-sdk-extension-aws` Release AWS Python SDK Extension as 1.0.0
10+
([#667](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/667))
11+
- `opentelemetry-instrumentation-sqlalchemy` Added `packaging` dependency
12+
([#713](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/713))
13+
914

1015
### Added
1116
- `opentelemetry-instrumentation-elasticsearch` Added `response_hook` and `request_hook` callbacks

Diff for: instrumentation/opentelemetry-instrumentation-sqlalchemy/setup.cfg

+1
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ install_requires =
4141
opentelemetry-api ~= 1.3
4242
opentelemetry-semantic-conventions == 0.24b0
4343
opentelemetry-instrumentation == 0.24b0
44+
packaging >= 21.0
4445
wrapt >= 1.11.2
4546

4647
[options.extras_require]

0 commit comments

Comments
 (0)