Skip to content

Commit 3b5ca07

Browse files
committed
Added asgiref depedency to opentelemetry-instrumentation-asgi
opentelemetry-instrumentaiton-asgi does not contain an instrumentor for asgiref. Instead, it implements an ASGI middleware that other instrumentors import and use. As such, other instrumentors can take a dependency on this package without asgiref being installed locally. This commit adds `asgiref` as a dependency to the opentelemetry-instrumentation-asgi package so the middleware can function properly when used by another instrumentation.
1 parent c24c77d commit 3b5ca07

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

88
## [Unreleased](https://github.com/open-telemetry/opentelemetry-python/compare/v1.6.2-0.25b2...HEAD)
9+
### Fixed
10+
11+
- `opentelemetry-instrumentation-asgi` now explicitly depends on asgiref as it uses the package instead of instrumenting it.
12+
([#765](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/765))
913

1014
## [1.6.2-0.25b2](https://github.com/open-telemetry/opentelemetry-python/releases/tag/v1.6.2-0.25b2) - 2021-10-19
1115

instrumentation/opentelemetry-instrumentation-asgi/setup.cfg

+1
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ install_requires =
4343
opentelemetry-semantic-conventions == 0.25b2
4444
opentelemetry-instrumentation == 0.25b2
4545
opentelemetry-util-http == 0.25b2
46+
asgiref ~= 3.0
4647

4748
[options.extras_require]
4849
test =

0 commit comments

Comments
 (0)