Skip to content

Commit 43eeddd

Browse files
Merge branch 'main' into fix-jinja2-template
2 parents 86e8542 + dbfa681 commit 43eeddd

File tree

8 files changed

+15
-8
lines changed

8 files changed

+15
-8
lines changed

.github/workflows/instrumentations_1.yml

+1
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ jobs:
3939
- "resource-detector-container"
4040
- "util-http"
4141
- "fastapi-slim"
42+
- "processor-baggage"
4243
os: [ubuntu-20.04]
4344
exclude:
4445
- python-version: pypy3

CONTRIBUTING.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,8 @@ The continuous integration overrides that environment variable with as per the c
250250
Below is a checklist of things to be mindful of when implementing a new instrumentation or working on a specific instrumentation. It is one of our goals as a community to keep the implementation specific details of instrumentations as similar across the board as possible for ease of testing and feature parity. It is also good to abstract as much common functionality as possible.
251251

252252
- Follow semantic conventions
253-
- The instrumentation should follow the semantic conventions defined [here](https://github.com/open-telemetry/opentelemetry-specification/tree/main/specification/semantic-conventions.md)
253+
- The instrumentation should follow the semantic conventions defined [here](https://github.com/open-telemetry/semantic-conventions/tree/main/docs)
254+
- Contains a name that is not already claimed in [Pypi](https://pypi.org/). Contact a maintainer, bring the issue up in the weekly Python SIG or create a ticket in Pypi if a desired name has already been taken.
254255
- Extends from [BaseInstrumentor](https://github.com/open-telemetry/opentelemetry-python-contrib/blob/2518a4ac07cb62ad6587dd8f6cbb5f8663a7e179/opentelemetry-instrumentation/src/opentelemetry/instrumentation/instrumentor.py#L35)
255256
- Supports auto-instrumentation
256257
- Add an entry point (ex. <https://github.com/open-telemetry/opentelemetry-python-contrib/blob/2518a4ac07cb62ad6587dd8f6cbb5f8663a7e179/instrumentation/opentelemetry-instrumentation-requests/pyproject.toml#L44>)

RELEASING.md

+4
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,10 @@
9090
<https://readthedocs.org/projects/opentelemetry-python/builds/>.
9191
If the build has not run automatically, it can be manually trigger via the readthedocs interface.
9292

93+
## Releasing dev version of new packages to claim namespace
94+
95+
When a contribution introduces a new package, in order to mitigate name-squatting incidents, release the current development version of the new package under the `opentelemetry` user to simply claim the namespace. This should be done shortly after the PR that introduced this package has been merged into `main`.
96+
9397
## Troubleshooting
9498

9599
### Publish failed

instrumentation/opentelemetry-instrumentation-asyncio/pyproject.toml

-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ dependencies = [
2828
"opentelemetry-api ~= 1.14",
2929
"opentelemetry-instrumentation == 0.48b0.dev",
3030
"opentelemetry-semantic-conventions == 0.48b0.dev",
31-
"opentelemetry-test-utils == 0.48b0.dev",
3231
"wrapt >= 1.0.0, < 2.0.0",
3332
]
3433

instrumentation/opentelemetry-instrumentation-fastapi/tests/test_fastapi_instrumentation.py

-1
Original file line numberDiff line numberDiff line change
@@ -768,7 +768,6 @@ def test_basic_metric_nonstandard_http_method_success_both_semconv(self):
768768
for point in list(metric.data.data_points):
769769
if isinstance(point, HistogramDataPoint):
770770
self.assertEqual(point.count, 1)
771-
self.assertAlmostEqual(duration, point.sum, delta=40)
772771
if metric.name == "http.server.request.duration":
773772
self.assertAlmostEqual(duration_s, point.sum, places=1)
774773
self.assertDictEqual(

instrumentation/opentelemetry-instrumentation-sqlalchemy/test-requirements-0.txt

-3
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
11
asgiref==3.7.2
22
cffi==1.15.1
33
Deprecated==1.2.14
4-
greenlet==0.4.13
5-
hpy==0.0.4.dev179+g9b5d200
64
importlib-metadata==6.11.0
75
iniconfig==2.0.0
86
packaging==24.0
97
pluggy==1.5.0
108
py-cpuinfo==9.0.0
119
pytest==7.4.4
12-
readline==6.2.4.1
1310
SQLAlchemy==1.1.18
1411
tomli==2.0.1
1512
typing_extensions==4.10.0

processor/opentelemetry-processor-baggage/pyproject.toml

+1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ classifiers = [
2626
]
2727
dependencies = [
2828
"opentelemetry-api ~= 1.5",
29+
"opentelemetry-sdk ~= 1.5",
2930
"wrapt >= 1.0.0, < 2.0.0",
3031
]
3132

Original file line numberDiff line numberDiff line change
@@ -1,2 +1,7 @@
1-
2-
-e processor/opentelemetry-processor-baggage
1+
importlib_metadata==8.0.0
2+
typing_extensions==4.12.2
3+
wrapt==1.16.0
4+
zipp==3.19.2
5+
pytest==7.4.4
6+
Deprecated==1.2.14
7+
-e processor/opentelemetry-processor-baggage

0 commit comments

Comments
 (0)