Skip to content

Commit 43f4bda

Browse files
committed
Fix extract checks
1 parent 95d964e commit 43f4bda

File tree

1 file changed

+8
-6
lines changed
  • propagator/opentelemetry-propagator-ot-trace/src/opentelemetry/propagators/ot_trace

1 file changed

+8
-6
lines changed

propagator/opentelemetry-propagator-ot-trace/src/opentelemetry/propagators/ot_trace/__init__.py

+8-6
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@
4040

4141
_valid_header_name = re_compile(r"^[\w_^`!#$%&'*+.|~]+$")
4242
_valid_header_value = re_compile(r"^[\t\x20-\x7e\x80-\xff]+$")
43-
_valid_extract_traceid = re_compile(r"[0-9a-f]{32}|[0-9a-f]{16}")
44-
_valid_extract_spanid = re_compile(r"[0-9a-f]{16}")
43+
_valid_extract_traceid = re_compile(r"[0-9a-f]{1,32}")
44+
_valid_extract_spanid = re_compile(r"[0-9a-f]{1,16}")
4545

4646

4747
class OTTracePropagator(TextMapPropagator):
@@ -60,7 +60,9 @@ def extract(
6060

6161
spanid = _extract_first_element(getter.get(carrier, OT_SPAN_ID_HEADER))
6262

63-
sampled = _extract_first_element(getter.get(carrier, OT_SAMPLED_HEADER))
63+
sampled = _extract_first_element(
64+
getter.get(carrier, OT_SAMPLED_HEADER)
65+
)
6466

6567
if sampled == "true":
6668
traceflags = TraceFlags.SAMPLED
@@ -92,9 +94,9 @@ def extract(
9294
if not key.startswith(OT_BAGGAGE_PREFIX):
9395
continue
9496

95-
baggage[key[len(OT_BAGGAGE_PREFIX):]] = _extract_first_element(
96-
getter.get(carrier, key)
97-
)
97+
baggage[
98+
key[len(OT_BAGGAGE_PREFIX) :]
99+
] = _extract_first_element(getter.get(carrier, key))
98100

99101
for key, value in baggage.items():
100102
context = set_baggage(key, value, context)

0 commit comments

Comments
 (0)