Skip to content

Commit 46b1466

Browse files
authored
adding gyliu513 as genai reviewer (#2972)
1 parent 1d6968b commit 46b1466

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

.github/component_owners.yml

+1
Original file line numberDiff line numberDiff line change
@@ -71,4 +71,5 @@ components:
7171
- karthikscale3
7272
- lmolkova
7373
- lzchen
74+
- gyliu513
7475
- nirga

CONTRIBUTING.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ Please also read the [OpenTelemetry Contributor Guide](https://github.com/open-t
3434
* [Testing against a different Core repo branch/commit](#testing-against-a-different-core-repo-branchcommit)
3535
* [Style Guide](#style-guide)
3636
* [Guideline for instrumentations](#guideline-for-instrumentations)
37-
* [Guidance for GenAI instrumentations](#guideline-for-genai-instrumentations)
37+
* [Guideline for GenAI instrumentations](#guideline-for-genai-instrumentations)
3838
* [Expectations from contributors](#expectations-from-contributors)
3939

4040
## Find a Buddy and get Started Quickly
@@ -273,13 +273,13 @@ Below is a checklist of things to be mindful of when implementing a new instrume
273273
- ex. <https://github.com/open-telemetry/opentelemetry-python-contrib/blob/60fb936b7e5371b3e5587074906c49fb873cbd76/instrumentation/opentelemetry-instrumentation-grpc/tests/test_aio_server_interceptor.py#L84>
274274
- All instrumentations have the same version. If you are going to develop a new instrumentation it would probably have `X.Y.dev` version and depends on `opentelemetry-instrumentation` and `opentelemetry-semantic-conventions` for the same version. That means that if you want to install your instrumentation you need to install its dependencies from this repo and the core repo also from git.
275275

276-
## Guidance for GenAI instrumentations
276+
## Guideline for GenAI instrumentations
277277

278-
Instrumentations that relate to [Generative AI](https://opentelemetry.io/docs/specs/semconv/gen-ai/) systems will be placed in the [genai](./instrumentation/genai) folder. This section covers contributions related to those instrumentations. Please note that the [guidelines for instrumentations](#guideline-for-instrumentations) and [expectations from contributors](#expectations-from-contributors) still apply.
278+
Instrumentations that relate to [Generative AI](https://opentelemetry.io/docs/specs/semconv/gen-ai/) systems will be placed in the [instrumentation-genai](./instrumentation-genai) folder. This section covers contributions related to those instrumentations. Please note that the [guidelines for instrumentations](#guideline-for-instrumentations) and [expectations from contributors](#expectations-from-contributors) still apply.
279279

280280
### Get Involved
281281

282-
* Reviewing PRs: If you would like to be tagged as reviewer in new PRs related to these instrumentations, please submit a PR to add your GitHub handle to [component_owners.yml](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2944/.github/component_owners.yml) under the corresponding instrumentation folder(s).
282+
* Reviewing PRs: If you would like to be tagged as reviewer in new PRs related to these instrumentations, please submit a PR to add your GitHub handle to [component_owners.yml](https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/.github/component_owners.yml) under the corresponding instrumentation folder(s).
283283

284284
* Approving PRs: If you would like to be able to approve PRs related to these instrumentations, you must join [opentelemetry-python-contrib-approvers](https://github.com/orgs/open-telemetry/teams/opentelemetry-python-contrib-approvers) team. Please ask one of the [Python contrib maintainers](https://github.com/orgs/open-telemetry/teams/opentelemetry-python-contrib-maintainers) to be accepted into the team.
285285

0 commit comments

Comments
 (0)