update asgi tests

macieyng · macieyng · commit 54ff3d48d4ad · 2023-04-15T23:56:00.000+02:00
diff --git a/instrumentation/opentelemetry-instrumentation-asgi/tests/test_asgi_middleware.py b/instrumentation/opentelemetry-instrumentation-asgi/tests/test_asgi_middleware.py
@@ -160,7 +160,7 @@ def validate_outputs(self, outputs, error=None, modifiers=None):
                 "attributes": {"type": "http.response.body"},
             },
             {
-                "name": "/",
+                "name": "GET /",
                 "kind": trace_api.SpanKind.SERVER,
                 "attributes": {
                     SpanAttributes.HTTP_METHOD: "GET",
@@ -284,6 +284,7 @@ def update_expected_server(expected):
                     SpanAttributes.HTTP_URL: "http://0.0.0.0/",
                 }
             )
+            # TODO:self possibly update span name to just method
             return expected
 
         self.scope["server"] = None

Original file line number	Diff line number	Diff line change
`@@ -160,7 +160,7 @@ def validate_outputs(self, outputs, error=None, modifiers=None):`
`160`	`160`	`"attributes": {"type": "http.response.body"},`
`161`	`161`	`},`
`162`	`162`	`{`
`163`		`- "name": "/",`
	`163`	`+ "name": "GET /",`
`164`	`164`	`"kind": trace_api.SpanKind.SERVER,`
`165`	`165`	`"attributes": {`
`166`	`166`	`SpanAttributes.HTTP_METHOD: "GET",`
`@@ -284,6 +284,7 @@ def update_expected_server(expected):`
`284`	`284`	`SpanAttributes.HTTP_URL: "http://0.0.0.0/",`
`285`	`285`	`}`
`286`	`286`	`)`
	`287`	`+ # TODO:self possibly update span name to just method`
`287`	`288`	`return expected`
`288`	`289`
`289`	`290`	`self.scope["server"] = None`