Skip to content

Commit 5606ce7

Browse files
committed
resolve conflicts
2 parents 4a2815d + f347716 commit 5606ce7

File tree

2 files changed

+8
-0
lines changed
  • instrumentation/opentelemetry-instrumentation-system-metrics/src/opentelemetry/instrumentation/system_metrics

2 files changed

+8
-0
lines changed

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
3131
([#1980](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1980))
3232
- `opentelemetry-resource-detector-azure` Using new Cloud Resource ID attribute.
3333
([#1976](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1976))
34+
- Do not collect `system.network.connections` by default on macOS which was causing exceptions in metrics collection.
35+
([#2008](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2008))
3436

3537
## Version 1.20.0/0.41b0 (2023-09-01)
3638

instrumentation/opentelemetry-instrumentation-system-metrics/src/opentelemetry/instrumentation/system_metrics/__init__.py

+6
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,8 @@
7676
"""
7777

7878
import gc
79+
import os
80+
import sys
7981
import logging
8082
import os
8183
import threading
@@ -119,6 +121,10 @@
119121
"process.runtime.context_switches": ["involuntary", "voluntary"],
120122
}
121123

124+
if sys.platform == "darwin":
125+
# see https://github.com/giampaolo/psutil/issues/1219
126+
_DEFAULT_CONFIG.pop("system.network.connections")
127+
122128

123129
class SystemMetricsInstrumentor(BaseInstrumentor):
124130
def __init__(

0 commit comments

Comments
 (0)