Skip to content

Commit 739e1f0

Browse files
authored
Merge branch 'main' into headers
2 parents f5b7288 + 79d00ee commit 739e1f0

File tree

3 files changed

+32
-25
lines changed

3 files changed

+32
-25
lines changed

.github/workflows/test.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ on:
66
- 'release/*'
77
pull_request:
88
env:
9-
CORE_REPO_SHA: 042d7a7921e25936decd95addf4fb1d30afb88e2
9+
CORE_REPO_SHA: e03650ac45cb74510f779f6e27fe4b920095f8be
1010

1111
jobs:
1212
build:

instrumentation/opentelemetry-instrumentation-tornado/tests/test_instrumentation.py

+26-22
Original file line numberDiff line numberDiff line change
@@ -494,28 +494,32 @@ def test_response_headers(self):
494494
self.memory_exporter.clear()
495495
set_global_response_propagator(orig)
496496

497-
def test_credential_removal(self):
498-
response = self.fetch(
499-
"http://username:[email protected]/status/200"
500-
)
501-
self.assertEqual(response.code, 200)
502-
503-
spans = self.sorted_spans(self.memory_exporter.get_finished_spans())
504-
self.assertEqual(len(spans), 1)
505-
client = spans[0]
506-
507-
self.assertEqual(client.name, "GET")
508-
self.assertEqual(client.kind, SpanKind.CLIENT)
509-
self.assertSpanHasAttributes(
510-
client,
511-
{
512-
SpanAttributes.HTTP_URL: "http://httpbin.org/status/200",
513-
SpanAttributes.HTTP_METHOD: "GET",
514-
SpanAttributes.HTTP_STATUS_CODE: 200,
515-
},
516-
)
517-
518-
self.memory_exporter.clear()
497+
# todo(srikanthccv): fix this test
498+
# this test is making request to real httpbin.org/status/200 which
499+
# is not a good idea as it can fail due to availability of the
500+
# service.
501+
# def test_credential_removal(self):
502+
# response = self.fetch(
503+
# "http://username:[email protected]/status/200"
504+
# )
505+
# self.assertEqual(response.code, 200)
506+
507+
# spans = self.sorted_spans(self.memory_exporter.get_finished_spans())
508+
# self.assertEqual(len(spans), 1)
509+
# client = spans[0]
510+
511+
# self.assertEqual(client.name, "GET")
512+
# self.assertEqual(client.kind, SpanKind.CLIENT)
513+
# self.assertSpanHasAttributes(
514+
# client,
515+
# {
516+
# SpanAttributes.HTTP_URL: "http://httpbin.org/status/200",
517+
# SpanAttributes.HTTP_METHOD: "GET",
518+
# SpanAttributes.HTTP_STATUS_CODE: 200,
519+
# },
520+
# )
521+
522+
# self.memory_exporter.clear()
519523

520524

521525
class TestTornadoInstrumentationWithXHeaders(TornadoTest):

tox.ini

+5-2
Original file line numberDiff line numberDiff line change
@@ -168,8 +168,11 @@ envlist =
168168
; instrumentation-remoulade intentionally excluded from pypy3
169169

170170
; opentelemetry-instrumentation-celery
171-
py3{7,8,9,10,11}-test-instrumentation-celery
172-
pypy3-test-instrumentation-celery
171+
; celery tests don't run on 3.7 because our opentelemetry-api requires importlib-metadata >= 5.0.0
172+
; but celery requires importlib-metadata < 5.0.0
173+
; see https://github.com/celery/celery/issues/7783 for more details
174+
py3{8,9,10,11}-test-instrumentation-celery
175+
; pypy3-test-instrumentation-celery
173176

174177
; opentelemetry-instrumentation-sklearn
175178
py3{7,8}-test-instrumentation-sklearn

0 commit comments

Comments
 (0)