Skip to content

Commit 799e84e

Browse files
authored
Merge branch 'main' into fix-flask-multithread-context-bug
2 parents 64b942f + bb41b46 commit 799e84e

File tree

5 files changed

+17
-4
lines changed

5 files changed

+17
-4
lines changed

instrumentation/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
| [opentelemetry-instrumentation-django](./opentelemetry-instrumentation-django) | django >= 1.10 | Yes
1717
| [opentelemetry-instrumentation-elasticsearch](./opentelemetry-instrumentation-elasticsearch) | elasticsearch >= 2.0 | No
1818
| [opentelemetry-instrumentation-falcon](./opentelemetry-instrumentation-falcon) | falcon >= 1.4.1, < 4.0.0 | Yes
19-
| [opentelemetry-instrumentation-fastapi](./opentelemetry-instrumentation-fastapi) | fastapi ~= 0.58 | Yes
19+
| [opentelemetry-instrumentation-fastapi](./opentelemetry-instrumentation-fastapi) | fastapi <= 0.90.1 | Yes
2020
| [opentelemetry-instrumentation-flask](./opentelemetry-instrumentation-flask) | flask >= 1.0, < 3.0 | Yes
2121
| [opentelemetry-instrumentation-grpc](./opentelemetry-instrumentation-grpc) | grpcio ~= 1.27 | No
2222
| [opentelemetry-instrumentation-httpx](./opentelemetry-instrumentation-httpx) | httpx >= 0.18.0 | No

instrumentation/opentelemetry-instrumentation-fastapi/pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ dependencies = [
3434

3535
[project.optional-dependencies]
3636
instruments = [
37-
"fastapi ~= 0.58",
37+
"fastapi <= 0.90.1",
3838
]
3939
test = [
4040
"opentelemetry-instrumentation-fastapi[instruments]",

instrumentation/opentelemetry-instrumentation-fastapi/src/opentelemetry/instrumentation/fastapi/package.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@
1313
# limitations under the License.
1414

1515

16-
_instruments = ("fastapi ~= 0.58",)
16+
_instruments = ("fastapi <= 0.90.1",)
1717

1818
_supports_metrics = True

instrumentation/opentelemetry-instrumentation-pymemcache/tests/test_pymemcache.py

+13
Original file line numberDiff line numberDiff line change
@@ -509,6 +509,19 @@ def test_uninstrumented(self):
509509

510510
PymemcacheInstrumentor().instrument()
511511

512+
def test_no_op_tracer_provider(self):
513+
PymemcacheInstrumentor().uninstrument()
514+
tracer_provider = trace_api.NoOpTracerProvider()
515+
PymemcacheInstrumentor().instrument(tracer_provider=tracer_provider)
516+
517+
client = self.make_client([b"STORED\r\n"])
518+
result = client.set(b"key", b"value", noreply=False)
519+
self.assertTrue(result)
520+
521+
spans = self.memory_exporter.get_finished_spans()
522+
assert spans is not None
523+
self.assertEqual(len(spans), 0)
524+
512525

513526
class PymemcacheHashClientTestCase(TestBase):
514527
"""Tests for a patched pymemcache.client.hash.HashClient."""

opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap_gen.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
"instrumentation": "opentelemetry-instrumentation-falcon==0.37b0.dev",
7070
},
7171
"fastapi": {
72-
"library": "fastapi ~= 0.58",
72+
"library": "fastapi <= 0.90.1",
7373
"instrumentation": "opentelemetry-instrumentation-fastapi==0.37b0.dev",
7474
},
7575
"flask": {

0 commit comments

Comments
 (0)