Skip to content

Commit 7be5095

Browse files
committed
Test for empty SQL strings in sqlcommenter
1 parent 18bbfdd commit 7be5095

File tree

1 file changed

+28
-0
lines changed

1 file changed

+28
-0
lines changed

instrumentation/opentelemetry-instrumentation-django/tests/test_sqlcommenter.py

+28
Original file line numberDiff line numberDiff line change
@@ -146,3 +146,31 @@ def test_multiple_connection_support(self, query_wrapper):
146146

147147
# check if query_wrapper is added to the context for 2 databases
148148
self.assertEqual(query_wrapper.call_count, 2)
149+
150+
@patch(
151+
"opentelemetry.instrumentation.django.middleware.sqlcommenter_middleware._get_opentelemetry_values"
152+
)
153+
def test_empty_sql(self, trace_capture):
154+
requests_mock = MagicMock()
155+
requests_mock.resolver_match.view_name = "view"
156+
requests_mock.resolver_match.route = "route"
157+
requests_mock.resolver_match.app_name = "app"
158+
159+
trace_capture.return_value = {
160+
"traceparent": "*traceparent='00-000000000000000000000000deadbeef-000000000000beef-00"
161+
}
162+
qw_instance = _QueryWrapper(requests_mock)
163+
execute_mock_obj = MagicMock()
164+
qw_instance(
165+
execute_mock_obj,
166+
"",
167+
MagicMock("test"),
168+
MagicMock("test1"),
169+
MagicMock(),
170+
)
171+
output_sql = execute_mock_obj.call_args[0][0]
172+
self.assertEqual(
173+
output_sql,
174+
" /*app_name='app',controller='view',route='route',traceparent='%%2Atraceparent%%3D%%2700-0000000"
175+
"00000000000000000deadbeef-000000000000beef-00'*/",
176+
)

0 commit comments

Comments
 (0)