Skip to content

Commit 86fe2e6

Browse files
GonzaloGuaschGonzaloGuasch
authored and
GonzaloGuasch
committed
Update changelog && change variable in test
1 parent 3e0ba7d commit 86fe2e6

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

CHANGELOG.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2222

2323
### Added
2424

25-
- `opentelemetry-instrumentation-flask` Add http route to metric attributes
25+
- `opentelemetry-instrumentation-flask` Add `http.route` to metric attributes
2626
([#2506](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2506))
2727
- `opentelemetry-sdk-extension-aws` Register AWS resource detectors under the
2828
`opentelemetry_resource_detector` entry point

instrumentation/opentelemetry-instrumentation-flask/tests/test_programmatic.py

+5-2
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,9 @@ def expected_attributes_new(override_attributes):
8585
return default_attributes
8686

8787

88+
_server_duration_attrs_old_copy = _server_duration_attrs_old.copy()
89+
_server_duration_attrs_old_copy.append("http.route")
90+
8891
_expected_metric_names_old = [
8992
"http.server.active_requests",
9093
"http.server.duration",
@@ -95,7 +98,7 @@ def expected_attributes_new(override_attributes):
9598
]
9699
_recommended_metrics_attrs_old = {
97100
"http.server.active_requests": _server_active_requests_count_attrs_old,
98-
"http.server.duration": _server_duration_attrs_old,
101+
"http.server.duration": _server_duration_attrs_old_copy,
99102
}
100103
_recommended_metrics_attrs_new = {
101104
"http.server.active_requests": _server_active_requests_count_attrs_new,
@@ -109,7 +112,7 @@ def expected_attributes_new(override_attributes):
109112
)
110113
_recommended_metrics_attrs_both = {
111114
"http.server.active_requests": _server_active_requests_count_attrs_both,
112-
"http.server.duration": _server_duration_attrs_old,
115+
"http.server.duration": _server_duration_attrs_old_copy,
113116
"http.server.request.duration": _server_duration_attrs_new,
114117
}
115118

0 commit comments

Comments
 (0)