Skip to content

Commit a0159a8

Browse files
committed
Update urllib implementation
1 parent 1ea0970 commit a0159a8

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

instrumentation/opentelemetry-instrumentation-urllib/src/opentelemetry/instrumentation/urllib/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ def _instrumented_open_call(
207207

208208
method = request.get_method().upper()
209209

210-
span_name = f"HTTP {method}".strip()
210+
span_name = method.strip()
211211

212212
url = remove_url_credentials(url)
213213

instrumentation/opentelemetry-instrumentation-urllib/tests/test_urllib_integration.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ def test_basic(self):
124124
span = self.assert_span()
125125

126126
self.assertIs(span.kind, trace.SpanKind.CLIENT)
127-
self.assertEqual(span.name, "HTTP GET")
127+
self.assertEqual(span.name, "GET")
128128

129129
self.assertEqual(
130130
span.attributes,
@@ -209,7 +209,7 @@ def test_response_code_none(self):
209209
span = self.assert_span()
210210

211211
self.assertIs(span.kind, trace.SpanKind.CLIENT)
212-
self.assertEqual(span.name, "HTTP GET")
212+
self.assertEqual(span.name, "GET")
213213

214214
self.assertEqual(
215215
span.attributes,

0 commit comments

Comments
 (0)